You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Balázs Donát Bessenyei <be...@apache.org> on 2017/02/21 15:54:25 UTC
Re: Review Request 52279: FLUME-2917 Provide netcat UDP source as
alternative to TCP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52279/#review166164
-----------------------------------------------------------
I was using https://gist.github.com/bessbd/8d5c07405fd8408f9db4673de291db92 as configuration and ```nc -u 127.0.0.1 6666``` to feed some input manually.
flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java (line 76)
<https://reviews.apache.org/r/52279/#comment238057>
Is there a way to rewrite this without mentioning syslog?
flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java (line 120)
<https://reviews.apache.org/r/52279/#comment238058>
Is there a way to rewrite this without mentioning syslog?
flume-ng-doc/sphinx/FlumeUserGuide.rst (line 1381)
<https://reviews.apache.org/r/52279/#comment238053>
I think this should be netcatudp
Also, for this to work I needed to add
```
/**
* Netcat UDP source.
*
* @see NetcatSource
*/
NETCATUDP("org.apache.flume.conf.source.NetcatUdpSourceConfiguration"),
```
to flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java
flume-ng-doc/sphinx/FlumeUserGuide.rst (line 1383)
<https://reviews.apache.org/r/52279/#comment238051>
Did you mean r1.port instead of r1.bind?
- Bal�zs Don�t Bessenyei
On Oct. 4, 2016, 11:30 a.m., Tristan Stevens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52279/
> -----------------------------------------------------------
>
> (Updated Oct. 4, 2016, 11:30 a.m.)
>
>
> Review request for Flume and Bal�zs Don�t Bessenyei.
>
>
> Repository: flume-git
>
>
> Description
> -------
>
> Implementation is heavily based on the existing SyslogUDPSource - the tests and implementation mirror that. We could consider making it a superclass of SyslogUDPSource and removing the syslog parsing, if this was felt tidier.
>
>
> Diffs
> -----
>
> flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java 4f4073a
> flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java PRE-CREATION
> flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java baa8500
> flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java PRE-CREATION
> flume-ng-doc/sphinx/FlumeUserGuide.rst ab71d38
>
> Diff: https://reviews.apache.org/r/52279/diff/
>
>
> Testing
> -------
>
> Unit tests provided.
>
>
> Thanks,
>
> Tristan Stevens
>
>