You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "Seetaramayya (via GitHub)" <gi...@apache.org> on 2023/01/21 13:40:39 UTC
[GitHub] [incubator-pekko] Seetaramayya opened a new pull request, #120: Replaced `doc.akka.io` with `pekko.apache.org`
Seetaramayya opened a new pull request, #120:
URL: https://github.com/apache/incubator-pekko/pull/120
Replaced `doc.akka.io` with `pekko.apache.org`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1084186468
##########
project/Publish.scala:
##########
@@ -35,10 +35,10 @@ object Publish extends AutoPlugin {
startYear := Some(2009),
developers := List(
Developer(
- "akka-contributors",
- "Akka Contributors",
+ "pekko-contributors",
+ "Pekko Contributors",
"akka.official@gmail.com",
Review Comment:
Ignore my previous comment, just now saw on main it is modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083447158
##########
docs/src/main/paradox/cluster-client.md:
##########
@@ -295,7 +295,7 @@ based API.
##### Initial contact points
-Instead of configured initial contact points the [Pekko gRPC Service Discovery](https://doc.akka.io/docs/akka-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
+Instead of configured initial contact points the [Pekko gRPC Service Discovery]($pekko.doc.dns$/docs/pekko-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
Review Comment:
`#using-akka-discovery-for-endpoint-discovery` should be `#using-pekko-discovery-for-endpoint-discovery`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083373902
##########
stream/src/main/scala/org/apache/pekko/stream/ActorMaterializer.scala:
##########
@@ -223,7 +223,7 @@ private[pekko] object ActorMaterializerHelper {
abstract class ActorMaterializer extends Materializer with MaterializerLoggingProvider {
@deprecated(
- "Use attributes to access settings from stages, see https://doc.akka.io/docs/akka/2.6/project/migration-guide-2.5.x-2.6.x.html",
+ "Use attributes to access settings from stages, see https://pekko.apache.org/docs/pekko/2.6/project/migration-guide-2.5.x-2.6.x.html",
Review Comment:
we have removed the akka migration guides - so best to revert this change so it links to the akka docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1409814444
@pjfanning Is it sufficient?
<img width="913" alt="image" src="https://user-images.githubusercontent.com/3521036/215679227-136db5b3-0896-4c53-8070-f8f79b85c0c3.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083373773
##########
remote/src/test/scala/org/apache/pekko/remote/Ticket1978CommunicationSpec.scala:
##########
@@ -193,7 +193,7 @@ abstract class Ticket1978CommunicationSpec(val cipherConfig: CipherConfig)
val compressed = baos.toByteArray
// random data should not be compressible
- // Another reproducer of https://doc.akka.io/docs/akka/current/security/2018-08-29-aes-rng.html
+ // Another reproducer of https://pekko.apache.org/docs/pekko/current/security/2018-08-29-aes-rng.html
Review Comment:
revert this - we are not keeping the akka security docs in the pekko doc clone - so best to link this to the akka docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083373653
##########
project/project-info.conf:
##########
@@ -14,6 +14,7 @@ project-info {
text: "Github issues"
}
release-notes: {
+ # TODO: Correct url needs to be provided
Review Comment:
remove the TODO, this problem URL is easily found when we come back to remove the final akka refs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1399309428
I did not fill Apache CLA agreement yet, I'll do it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083313727
##########
actor-testkit-typed/src/main/scala/org/apache/pekko/actor/testkit/typed/internal/StubbedActorContext.scala:
##########
@@ -55,7 +55,7 @@ private[pekko] final class FunctionRef[-T](override val path: ActorPath, send: (
override def provider: ActorRefProvider =
throw new UnsupportedOperationException(
"ActorRefs created for synchronous testing cannot be used as targets for asking. Use asynchronous testing instead. " +
- "See https://doc.akka.io/docs/akka/current/typed/testing.html#asynchronous-testing")
+ "See https://pekko.apache.org/docs/akka/current/typed/testing.html#asynchronous-testing")
Review Comment:
@Seetaramayya I published https://pekko.apache.org/ - if you change the URLs to use `docs/pekko` instead of `docs/akka` then they should work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1084188268
##########
project/Publish.scala:
##########
@@ -35,10 +35,10 @@ object Publish extends AutoPlugin {
startYear := Some(2009),
developers := List(
Developer(
- "akka-contributors",
- "Akka Contributors",
+ "pekko-contributors",
+ "Pekko Contributors",
"akka.official@gmail.com",
Review Comment:
This was already merged on the main branch - earlier today (another PR) - I've fixed the conflict in your PR - could you update your local copy of the branch to pick this up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1084181757
##########
project/Publish.scala:
##########
@@ -35,10 +35,10 @@ object Publish extends AutoPlugin {
startYear := Some(2009),
developers := List(
Developer(
- "akka-contributors",
- "Akka Contributors",
+ "pekko-contributors",
+ "Pekko Contributors",
"akka.official@gmail.com",
Review Comment:
What is the equivalent email address for `akka.official@gmail.com` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083437469
##########
project/Paradox.scala:
##########
@@ -23,26 +23,27 @@ import sbt._
import scala.concurrent.duration._
object Paradox {
-
+ val pekkoBaseURL = "https://pekko.apache.org"
val propertiesSettings = Seq(
Compile / paradoxProperties ++= Map(
- "canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
+ "canonical.base_url" -> s"$pekkoBaseURL/docs/pekko/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.pekko.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
- "extref.pekko-management.base_url" -> "https://doc.akka.io/docs/akka-management/current/%s",
- "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
+ "extref.pekko.http.base_url" -> s"$pekkoBaseURL/docs/pekko-http/current/%s",
+ "extref.pekko-management.base_url" -> s"$pekkoBaseURL/docs/pekko-management/current/%s",
+ "extref.platform-guide.base_url" -> s"$pekkoBaseURL/",
"extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
"extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
"extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
Review Comment:
just add issues for anything you are skipping
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083569591
##########
project/Doc.scala:
##########
@@ -74,7 +74,7 @@ object Scaladoc extends AutoPlugin {
"-doc-version",
ver,
"-doc-canonical-base-url",
- "https://doc.akka.io/api/akka/current/")
Review Comment:
A couple of lines above this - could you replace this?
```
"-doc-title",
"Akka",
```
with
```
"-doc-title",
"Apache Pekko",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1399294064
@Seetaramayya have you filled in an Apache CLA? We'll need one for a big change like this. See https://github.com/apache/incubator-pekko/Contributing,md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083334956
##########
actor/src/main/scala/org/apache/pekko/io/Udp.scala:
##########
@@ -36,7 +36,7 @@ import pekko.util.ccompat._
* from whom data can be received. For “connected” UDP mode see [[UdpConnected]].
*
* For a full description of the design and philosophy behind this IO
- * implementation please refer to <a href="https://akka.io/docs/">the Akka online documentation</a>.
+ * implementation please refer to <a href="https://pekko.apache.org/docs/pekko/current/">the Akka online documentation</a>.
Review Comment:
Could you replace 'the Akka online documentation'?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083437160
##########
project/Paradox.scala:
##########
@@ -23,26 +23,27 @@ import sbt._
import scala.concurrent.duration._
object Paradox {
-
+ val pekkoBaseURL = "https://pekko.apache.org"
val propertiesSettings = Seq(
Compile / paradoxProperties ++= Map(
- "canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
+ "canonical.base_url" -> s"$pekkoBaseURL/docs/pekko/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.pekko.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
- "extref.pekko-management.base_url" -> "https://doc.akka.io/docs/akka-management/current/%s",
- "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
+ "extref.pekko.http.base_url" -> s"$pekkoBaseURL/docs/pekko-http/current/%s",
+ "extref.pekko-management.base_url" -> s"$pekkoBaseURL/docs/pekko-management/current/%s",
+ "extref.platform-guide.base_url" -> s"$pekkoBaseURL/",
"extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
"extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
"extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
Review Comment:
I don't think `extref.samples.base_url` exist. This results `404`s on lightbend side because `.*pekko.*` project does not exists on their side. For example,
```
https://developer.lightbend.com/start/?group=akka&project=pekko-sample-cluster-docker-compose-scala
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1410158158
@Seetaramayya could you tell me the email address that you used to get the iCLA - because I can't find your iCLA in the ASF app and it is based on email addresses?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083437160
##########
project/Paradox.scala:
##########
@@ -23,26 +23,27 @@ import sbt._
import scala.concurrent.duration._
object Paradox {
-
+ val pekkoBaseURL = "https://pekko.apache.org"
val propertiesSettings = Seq(
Compile / paradoxProperties ++= Map(
- "canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
+ "canonical.base_url" -> s"$pekkoBaseURL/docs/pekko/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.pekko.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
- "extref.pekko-management.base_url" -> "https://doc.akka.io/docs/akka-management/current/%s",
- "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
+ "extref.pekko.http.base_url" -> s"$pekkoBaseURL/docs/pekko-http/current/%s",
+ "extref.pekko-management.base_url" -> s"$pekkoBaseURL/docs/pekko-management/current/%s",
+ "extref.platform-guide.base_url" -> s"$pekkoBaseURL/",
"extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
"extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
"extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
Review Comment:
I don't think `extref.samples.base_url` exist. This results `404`s on lightbend side because `.*pekko.*` project does not exists on their side.
For example,
```
https://developer.lightbend.com/start/?group=akka&project=pekko-sample-cluster-docker-compose-scala
```
I found `76` references like this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083440520
##########
cluster-tools/src/main/scala/org/apache/pekko/cluster/client/ClusterClient.scala:
##########
@@ -127,7 +127,7 @@ object ClusterClientSettings {
* external service registry
*/
@deprecated(
- "Use Akka gRPC instead, see https://doc.akka.io/docs/akka/2.6/cluster-client.html#migration-to-akka-grpc",
+ "Use Akka gRPC instead, see https://pekko.apache.org/docs/pekko/2.6/cluster-client.html#migration-to-akka-grpc",
Review Comment:
can you fix up the rest of this class - should not have `pekko/2.6` - use `pekko/current`
##########
cluster-tools/src/main/scala/org/apache/pekko/cluster/client/ClusterClient.scala:
##########
@@ -127,7 +127,7 @@ object ClusterClientSettings {
* external service registry
*/
@deprecated(
- "Use Akka gRPC instead, see https://doc.akka.io/docs/akka/2.6/cluster-client.html#migration-to-akka-grpc",
+ "Use Akka gRPC instead, see https://pekko.apache.org/docs/pekko/2.6/cluster-client.html#migration-to-akka-grpc",
Review Comment:
can you fix up the rest of this class? - should not have `pekko/2.6` - use `pekko/current`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083328293
##########
cluster-tools/src/main/scala/org/apache/pekko/cluster/client/ClusterClient.scala:
##########
@@ -56,7 +56,7 @@ import pekko.util.ccompat._
@ccompatUsedUntil213
@deprecated(
- "Use Akka gRPC instead, see https://pekko.apache.org/docs/akka/2.6/cluster-client.html#migration-to-akka-grpc",
+ "Use Akka gRPC instead, see https://pekko.apache.org/docs/pekko/2.6/cluster-client.html#migration-to-akka-grpc",
Review Comment:
2.6 is wrong - that is an akka version number - no pekko 2.6 exists
could you check the `migration-to-akka-grpc` bit too? remember that this is pekko, not akka
cluster-client.md may not yet have that header renamed but it should be - could you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083336910
##########
cluster-tools/src/main/scala/org/apache/pekko/cluster/client/ClusterClient.scala:
##########
@@ -56,7 +56,7 @@ import pekko.util.ccompat._
@ccompatUsedUntil213
@deprecated(
- "Use Akka gRPC instead, see https://pekko.apache.org/docs/akka/2.6/cluster-client.html#migration-to-akka-grpc",
+ "Use Akka gRPC instead, see https://pekko.apache.org/docs/pekko/2.6/cluster-client.html#migration-to-akka-grpc",
Review Comment:
Whole migration section can be deleted and reference `pekko-grpc` link
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1399460602
What to do?
Still I see some references to `lightbend` guides, for example
```
https://developer.lightbend.com/guides/akka-quickstart-scala/
```
in `exampels.md`, `introduction.md`, `tutorial.md` and `tutorial_1.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083440995
##########
docs/src/main/paradox/cluster-client.md:
##########
@@ -295,7 +295,7 @@ based API.
##### Initial contact points
-Instead of configured initial contact points the [Pekko gRPC Service Discovery](https://doc.akka.io/docs/akka-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
+Instead of configured initial contact points the [Pekko gRPC Service Discovery]($pekko.doc.dns$/docs/pekko-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
Review Comment:
pekko-discovery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083440896
##########
docs/src/main/paradox/.htaccess:
##########
@@ -18,9 +18,9 @@ RedirectMatch 301 ^(.*[^d])/guide/(.*) $1/typed/guide/$2
RedirectMatch 301 ^(.*)/additional/rolling-deploys\.html$ $1/additional/rolling-updates.html
RedirectMatch 301 ^(.*)/additional/index\.html$ $1/project/index.html
-RedirectMatch 301 ^(.*)/howto\.html$ https://doc.akka.io/docs/akka/2.5/howto.html
-RedirectMatch 301 ^(.*)/common/duration\.html$ https://doc.akka.io/docs/akka/2.5/common/duration.html
-RedirectMatch 301 ^(.*)/java8-compat\.html$ https://doc.akka.io/docs/akka/2.5/java8-compat.html
+RedirectMatch 301 ^(.*)/howto\.html$ https://pekko.apache.org/docs/pekko/2.5/howto.html
Review Comment:
remove the redirects that mention pekko/2.5 - we don't need these redirects
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1399461513
> What to do? Still I see some references to `lightbend` guides, for example
>
> ```
> https://developer.lightbend.com/guides/akka-quickstart-scala/
> ```
>
> in `exampels.md`, `introduction.md`, `tutorial.md` and `tutorial_1.md`
we can't fix everything today - I've raised https://github.com/apache/incubator-pekko/issues/123 to come back to this bit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1410168976
@pjfanning Sent my email address in gitter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083328432
##########
docs/src/main/paradox/cluster-client.md:
##########
@@ -38,8 +38,8 @@ i.e. not necessarily the initial contact points.
Using the @apidoc[ClusterClient] for communicating with a cluster from the outside requires that the system with the client
can both connect and be connected with Pekko Remoting from all the nodes in the cluster with a receptionist.
This creates a tight coupling in that the client and cluster systems may need to have the same version of both Pekko, libraries, message classes, serializers and potentially even the JVM. In many cases it is a better solution
-to use a more explicit and decoupling protocol such as [HTTP](https://doc.akka.io/docs/akka-http/current/index.html) or
-[gRPC](https://doc.akka.io/docs/akka-grpc/current/).
+to use a more explicit and decoupling protocol such as [HTTP]($pekko.doc.dns$/docs/akka-http/current/index.html) or
+[gRPC]($pekko.doc.dns$/docs/akka-grpc/current/).
Review Comment:
pekko-http
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083437160
##########
project/Paradox.scala:
##########
@@ -23,26 +23,27 @@ import sbt._
import scala.concurrent.duration._
object Paradox {
-
+ val pekkoBaseURL = "https://pekko.apache.org"
val propertiesSettings = Seq(
Compile / paradoxProperties ++= Map(
- "canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
+ "canonical.base_url" -> s"$pekkoBaseURL/docs/pekko/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.pekko.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
- "extref.pekko-management.base_url" -> "https://doc.akka.io/docs/akka-management/current/%s",
- "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
+ "extref.pekko.http.base_url" -> s"$pekkoBaseURL/docs/pekko-http/current/%s",
+ "extref.pekko-management.base_url" -> s"$pekkoBaseURL/docs/pekko-management/current/%s",
+ "extref.platform-guide.base_url" -> s"$pekkoBaseURL/",
"extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
"extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
"extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
Review Comment:
I don't think `extref.samples.base_url` exist. This results `404`s on lightbend side because `.*pekko.*` project does not exists on their side.
For example,
```
https://developer.lightbend.com/start/?group=akka&project=pekko-sample-cluster-docker-compose-scala
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1399465592
> I did not fill Apache CLA agreement yet, today I'll do it.
Done, I got confirmation that `ICLA has been filed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083295305
##########
actor-testkit-typed/src/main/scala/org/apache/pekko/actor/testkit/typed/internal/StubbedActorContext.scala:
##########
@@ -55,7 +55,7 @@ private[pekko] final class FunctionRef[-T](override val path: ActorPath, send: (
override def provider: ActorRefProvider =
throw new UnsupportedOperationException(
"ActorRefs created for synchronous testing cannot be used as targets for asking. Use asynchronous testing instead. " +
- "See https://doc.akka.io/docs/akka/current/typed/testing.html#asynchronous-testing")
+ "See https://pekko.apache.org/docs/akka/current/typed/testing.html#asynchronous-testing")
Review Comment:
there will be no akka in pekko.apache.org paths (ie the `docs/akka` bit) - Pekko team still needs to discuss what paths will end up looking like
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083322711
##########
project/Paradox.scala:
##########
@@ -23,26 +23,27 @@ import sbt._
import scala.concurrent.duration._
object Paradox {
-
+ val pekkoBaseURL = "https://pekko.apache.org"
val propertiesSettings = Seq(
Compile / paradoxProperties ++= Map(
- "canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
+ "canonical.base_url" -> s"$pekkoBaseURL/docs/akka/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.pekko.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
- "extref.pekko-management.base_url" -> "https://doc.akka.io/docs/akka-management/current/%s",
+ "extref.pekko.http.base_url" -> s"$pekkoBaseURL/docs/akka-http/current/%s",
+ "extref.pekko-management.base_url" -> s"$pekkoBaseURL/docs/akka-management/current/%s",
"extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
"extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
"extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
"extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
"extref.ecs.base_url" -> "https://example.lightbend.com/v1/download/%s",
- "scaladoc.pekko.base_url" -> "https://doc.akka.io/api/akka/2.6/org/apache",
- "scaladoc.pekko.http.base_url" -> "https://doc.akka.io/api/akka-http/current/org/apache",
+ "pekko.doc.dns" -> s"$pekkoBaseURL",
+ "scaladoc.pekko.base_url" -> s"$pekkoBaseURL/api/akka/2.6/org/apache",
Review Comment:
any path with `/akka` in will need to change to `/pekko`
paths like `akka-http` will need to change to `pekko-http` -- likewise for `akka-management`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083373940
##########
stream/src/main/scala/org/apache/pekko/stream/ActorMaterializer.scala:
##########
@@ -223,7 +223,7 @@ private[pekko] object ActorMaterializerHelper {
abstract class ActorMaterializer extends Materializer with MaterializerLoggingProvider {
@deprecated(
- "Use attributes to access settings from stages, see https://doc.akka.io/docs/akka/2.6/project/migration-guide-2.5.x-2.6.x.html",
+ "Use attributes to access settings from stages, see https://pekko.apache.org/docs/pekko/2.6/project/migration-guide-2.5.x-2.6.x.html",
Review Comment:
all other changes like this should be reverted too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083334837
##########
persistence/src/main/resources/reference.conf:
##########
@@ -5,7 +5,8 @@
# This is the reference config file that contains all the default settings.
# Make your edits in your application.conf in order to override these settings.
-# Directory of persistence journal and snapshot store plugins is available at the
+# Directory of persistence journal and snapshot store plugins is available at the
+# TODO: Do we need to extend community url of pekko as well along with akka community?
Review Comment:
please remove the TODO - the fact that the akka url is there will attract attention
it's ok to leave the https://akka.io/community/ as is until we work out what to replace it with
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083373468
##########
project/Paradox.scala:
##########
@@ -23,26 +23,27 @@ import sbt._
import scala.concurrent.duration._
object Paradox {
-
+ val pekkoBaseURL = "https://pekko.apache.org"
val propertiesSettings = Seq(
Compile / paradoxProperties ++= Map(
- "canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
+ "canonical.base_url" -> s"$pekkoBaseURL/docs/pekko/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.pekko.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
- "extref.pekko-management.base_url" -> "https://doc.akka.io/docs/akka-management/current/%s",
- "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
+ "extref.pekko.http.base_url" -> s"$pekkoBaseURL/docs/pekko-http/current/%s",
+ "extref.pekko-management.base_url" -> s"$pekkoBaseURL/docs/pekko-management/current/%s",
+ "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/pekko-platform-guide/%s",
Review Comment:
change the host to $pekkoBaseURL/ - we'll host the pekko-platform-guide there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083373549
##########
project/Publish.scala:
##########
@@ -49,6 +49,7 @@ object Publish extends AutoPlugin {
val key = new java.io.File(
Option(System.getProperty("pekko.gustav.key"))
.getOrElse(System.getProperty("user.home") + "/.ssh/id_rsa_gustav.pem"))
+ // TODO: gustav.pekko.io?
Review Comment:
remove the TODO, we'll sort out the rsync stuff later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083445817
##########
docs/src/main/paradox/cluster-client.md:
##########
@@ -295,7 +295,7 @@ based API.
##### Initial contact points
-Instead of configured initial contact points the [Pekko gRPC Service Discovery](https://doc.akka.io/docs/akka-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
+Instead of configured initial contact points the [Pekko gRPC Service Discovery]($pekko.doc.dns$/docs/pekko-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
Review Comment:
As far as I understand, we need to refer https://github.com/apache/incubator-pekko-grpc/blob/main/docs/src/main/paradox/client/configuration.md#using-akka-discovery-for-endpoint-discovery from this location, this should be access by `pekk-grpc` right?
or Am I miss understanding something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1084179890
##########
project/Doc.scala:
##########
@@ -74,7 +74,7 @@ object Scaladoc extends AutoPlugin {
"-doc-version",
ver,
"-doc-canonical-base-url",
- "https://doc.akka.io/api/akka/current/")
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083335112
##########
docs/src/main/paradox/common/other-modules.md:
##########
@@ -1,62 +1,62 @@
# Other Pekko modules
-This page describes modules that compliment libraries from the Pekko core. See [this overview](https://doc.akka.io/docs/akka/current/typed/guide/modules.html) instead for a guide on the core modules.
+This page describes modules that compliment libraries from the Pekko core. See [this overview]($pekko.doc.dns$/docs/pekko/current/typed/guide/modules.html) instead for a guide on the core modules.
-## [Pekko HTTP](https://doc.akka.io/docs/akka-http/current/)
+## [Pekko HTTP]($pekko.doc.dns$/docs/pekko-http/current/)
A full server- and client-side HTTP stack on top of pekko-actor and pekko-stream.
-## [Pekko gRPC](https://doc.akka.io/docs/akka-grpc/current/)
+## [Pekko gRPC]($pekko.doc.dns$/docs/pekko-grpc/current/)
Pekko gRPC provides support for building streaming gRPC servers and clients on top of Pekko Streams.
-## [Pekko Connectors](https://doc.akka.io/docs/alpakka/current/)
+## [Pekko Connectors]($pekko.doc.dns$/docs/alpakka/current/)
Pekko Connectors is a Reactive Enterprise Integration library for Java and Scala, based on Reactive Streams and Pekko.
-## [Pekko Kafka Connector](https://doc.akka.io/docs/alpakka-kafka/current/)
+## [Pekko Kafka Connector]($pekko.doc.dns$/docs/alpakka-kafka/current/)
Review Comment:
alpakka-kafka is wrong - should be pekko-connectors-kafka
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#issuecomment-1409345488
@Seetaramayya have you started the process of getting the CLA approved?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083373807
##########
remote/src/test/scala/org/apache/pekko/remote/artery/tcp/SecureRandomFactorySpec.scala:
##########
@@ -51,7 +51,7 @@ abstract class SecureRandomFactorySpec(alg: String) extends PekkoSpec {
"generate random" in {
val bytes = Array.ofDim[Byte](16)
// Reproducer of the specific issue described at
- // https://doc.akka.io/docs/akka/current/security/2018-08-29-aes-rng.html
+ // https://pekko.apache.org/docs/pekko/current/security/2018-08-29-aes-rng.html
Review Comment:
revert this - we are not keeping the akka security docs in the pekko doc clone - so best to link this to the akka docs
##########
remote/src/test/scala/org/apache/pekko/remote/artery/tcp/SecureRandomFactorySpec.scala:
##########
@@ -75,7 +75,7 @@ abstract class SecureRandomFactorySpec(alg: String) extends PekkoSpec {
val compressed = baos.toByteArray
// random data should not be compressible
- // Another reproducer of https://doc.akka.io/docs/akka/current/security/2018-08-29-aes-rng.html
+ // Another reproducer of https://pekko.apache.org/docs/pekko/current/security/2018-08-29-aes-rng.html
Review Comment:
revert this - we are not keeping the akka security docs in the pekko doc clone - so best to link this to the akka docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1084184726
##########
project/Publish.scala:
##########
@@ -35,10 +35,10 @@ object Publish extends AutoPlugin {
startYear := Some(2009),
developers := List(
Developer(
- "akka-contributors",
- "Akka Contributors",
+ "pekko-contributors",
+ "Pekko Contributors",
"akka.official@gmail.com",
Review Comment:
use `dev@pekko.apache.org`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083439282
##########
project/Paradox.scala:
##########
@@ -23,26 +23,27 @@ import sbt._
import scala.concurrent.duration._
object Paradox {
-
+ val pekkoBaseURL = "https://pekko.apache.org"
val propertiesSettings = Seq(
Compile / paradoxProperties ++= Map(
- "canonical.base_url" -> "https://doc.akka.io/docs/akka/current",
+ "canonical.base_url" -> s"$pekkoBaseURL/docs/pekko/current",
"github.base_url" -> GitHub
.url(version.value), // for links like this: @github[#1](#1) or @github[83986f9](83986f9)
- "extref.pekko.http.base_url" -> "https://doc.akka.io/docs/akka-http/current/%s",
- "extref.pekko-management.base_url" -> "https://doc.akka.io/docs/akka-management/current/%s",
- "extref.platform-guide.base_url" -> "https://developer.lightbend.com/docs/akka-platform-guide/%s",
+ "extref.pekko.http.base_url" -> s"$pekkoBaseURL/docs/pekko-http/current/%s",
+ "extref.pekko-management.base_url" -> s"$pekkoBaseURL/docs/pekko-management/current/%s",
+ "extref.platform-guide.base_url" -> s"$pekkoBaseURL/",
"extref.wikipedia.base_url" -> "https://en.wikipedia.org/wiki/%s",
"extref.github.base_url" -> (GitHub.url(version.value) + "/%s"), // for links to our sources
"extref.samples.base_url" -> "https://developer.lightbend.com/start/?group=akka&project=%s",
Review Comment:
Added an issue https://github.com/apache/incubator-pekko/issues/124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083447702
##########
docs/src/main/paradox/cluster-client.md:
##########
@@ -295,7 +295,7 @@ based API.
##### Initial contact points
-Instead of configured initial contact points the [Pekko gRPC Service Discovery](https://doc.akka.io/docs/akka-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
+Instead of configured initial contact points the [Pekko gRPC Service Discovery]($pekko.doc.dns$/docs/pekko-grpc/current/client/configuration.html#using-akka-discovery-for-endpoint-discovery) can be used.
Review Comment:
Okay, I'll change it. `#` link will not work until we change in `incubator-pekko-grpc` project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083325169
##########
persistence/src/main/resources/reference.conf:
##########
@@ -5,7 +5,8 @@
# This is the reference config file that contains all the default settings.
# Make your edits in your application.conf in order to override these settings.
-# Directory of persistence journal and snapshot store plugins is available at the
+# Directory of persistence journal and snapshot store plugins is available at the
+# TODO: Do we need to extend community url of pekko as well along with akka community?
Review Comment:
I don't know what to do, so left `TODO`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] Seetaramayya commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "Seetaramayya (via GitHub)" <gi...@apache.org>.
Seetaramayya commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083325328
##########
project/project-info.conf:
##########
@@ -14,6 +14,7 @@ project-info {
text: "Github issues"
}
release-notes: {
+ # TODO: Correct url needs to be provided
Review Comment:
Added another `TODO`. Release notes page needs to be added in future. Shall I create a task / issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083328396
##########
docs/src/main/paradox/cluster-client.md:
##########
@@ -2,7 +2,7 @@
@@@ warning
-Cluster Client is deprecated in favor of using [Pekko gRPC](https://doc.akka.io/docs/akka-grpc/current/index.html).
+Cluster Client is deprecated in favor of using [Pekko gRPC]($pekko.doc.dns$/docs/akka-grpc/current/index.html).
Review Comment:
akka-grpc is renamed to pekko-grpc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #120: Replaced `doc.akka.io` with `pekko.apache.org`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #120:
URL: https://github.com/apache/incubator-pekko/pull/120#discussion_r1083335085
##########
docs/src/main/paradox/common/other-modules.md:
##########
@@ -1,62 +1,62 @@
# Other Pekko modules
-This page describes modules that compliment libraries from the Pekko core. See [this overview](https://doc.akka.io/docs/akka/current/typed/guide/modules.html) instead for a guide on the core modules.
+This page describes modules that compliment libraries from the Pekko core. See [this overview]($pekko.doc.dns$/docs/pekko/current/typed/guide/modules.html) instead for a guide on the core modules.
-## [Pekko HTTP](https://doc.akka.io/docs/akka-http/current/)
+## [Pekko HTTP]($pekko.doc.dns$/docs/pekko-http/current/)
A full server- and client-side HTTP stack on top of pekko-actor and pekko-stream.
-## [Pekko gRPC](https://doc.akka.io/docs/akka-grpc/current/)
+## [Pekko gRPC]($pekko.doc.dns$/docs/pekko-grpc/current/)
Pekko gRPC provides support for building streaming gRPC servers and clients on top of Pekko Streams.
-## [Pekko Connectors](https://doc.akka.io/docs/alpakka/current/)
Review Comment:
alpakka is wrong - should be pekko-connectors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org