Re: Review Request 65666: Added a unit test for SLRP operation state metrics.

[Chun-Hung Hsiao <ch...@apache.org>]

> On March 26, 2018, 2:27 p.m., Jan Schlicht wrote:
> > This is missing a test for `operations_pending`. You could wait with a `DROP_PROTOBUF(UpdateOperationStatusMessage)` after applying an operation, then check that `operations_pending` is "1", then (manually) send the `UpdateOperationStatusMessage` and check the `operation_pending` is back to "0".
> 
> Chun-Hung Hsiao wrote:
>     Hmm seems I'll have to stop the clock for this test.

The `operations_pending` metric is not affected by dropping the message; it is related to the internal state of the resource provider which no control is exposed right now. A potential way to test this is that we could support out-of-band CSI plugins through domain sockets, and use a mock CSI plugin that can be controlled in the test. I'll add a TODO for this.


- Chun-Hung


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65666/#review199669
-----------------------------------------------------------


On March 20, 2018, 3:27 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65666/
> -----------------------------------------------------------
> 
> (Updated March 20, 2018, 3:27 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht.
> 
> 
> Bugs: MESOS-8383
>     https://issues.apache.org/jira/browse/MESOS-8383
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds the `ROOT_OperationStateMetrics` test that issues a
> `CREATE_VOLUME` followed by two `DESTROY_VOLUME`s. The first one will
> fail due to an out-of-band deletion of the actual volume, and the second
> one will fail due to modifying the resource version.
> 
> 
> Diffs
> -----
> 
>   src/tests/storage_local_resource_provider_tests.cpp 264d42b57fe1a8ea04c1de0a10112878c7b45d39 
> 
> 
> Diff: https://reviews.apache.org/r/65666/diff/3/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>