You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by yzlai <gi...@git.apache.org> on 2014/03/03 03:42:18 UTC
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
GitHub user yzlai opened a pull request:
https://github.com/apache/trafficserver/pull/53
TS-2604: collapsed connection plugin
This plugin collapses connections with identical CacheUrl/EffectiveUrl.
Please kindly review it.
Detailed info can be found from README and state.png
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yzlai/trafficserver TS-2604
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 2b27f9ccf76e2033fc5b465773edb2230e6928e0
Author: Ethan Lai <yz...@yahoo.com>
Date: 2014-03-03T02:38:26Z
TS-2604: collapsed connection plugin
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/53#issuecomment-53082948
This was merged as 2ddcc688403eabf71cde47855d9f1377196583be. Please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by yzlai <gi...@git.apache.org>.
Github user yzlai commented on the pull request:
https://github.com/apache/trafficserver/pull/53#issuecomment-36570580
Faysal,
Could you please enable debug mode with "collapsed_connection.*" pattern, and kindly give me some related debug messages with this not working case?
It would be very helpful to make this plugin do work. :)
Thanks,
-Ethan
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by Degreane <gi...@git.apache.org>.
Github user Degreane commented on the pull request:
https://github.com/apache/trafficserver/pull/53#issuecomment-40795152
Sir. This plugin does not even get pulled into trafficserver 5.0.0
could u check it please ?
much regards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by Degreane <gi...@git.apache.org>.
Github user Degreane commented on the pull request:
https://github.com/apache/trafficserver/pull/53#issuecomment-36556479
Sir.
first of all i did git pull as u described .
it didn't compile the plugin with default compile methods then i went doing
tsxs -o collapsed_connection.so collapsed_connection.cc
afterwards copied collapsed_connection.so to /usr/local/libexec/trafficserver
as usual where my lib for traffic server resides
enabled the plugin as your README says
with the config example as u provided
the plugin loaded fine but then i got an error
[Mar 4 06:26:29.477] Server {0x2b242f2ca240} NOTE: cache clustering disabled
[Mar 4 06:26:29.482] Server {0x2b242f2ca240} NOTE: ip_allow.config updated, reloading
[Mar 4 06:26:29.485] Server {0x2b242f2ca240} NOTE: cache clustering disabled
[Mar 4 06:26:29.486] Server {0x2b242f2ca240} NOTE: logging initialized[3], logging_mode = 3
[Mar 4 06:26:29.486] Server {0x2b242f2ca240} NOTE: loading plugin '/usr/local/libexec/trafficserver/cacheurl.so'
[Mar 4 06:26:29.486] Server {0x2b242f2ca240} NOTE: loading plugin '/usr/local/libexec/trafficserver/collapsed_connection.so'
[Mar 4 06:26:29.487] Server {0x2b242f2ca240} FATAL: unable to load '/usr/local/libexec/trafficserver/collapsed_connection.so': /usr/local/libexec/trafficserver/collapsed_connection.so: undefined symbol: _Z18MurmurHash3_x86_32PKvijPv
hope this helps
much regards
Faysal Banna
degreane@gmail.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by Degreane <gi...@git.apache.org>.
Github user Degreane commented on the pull request:
https://github.com/apache/trafficserver/pull/53#issuecomment-36565831
Sir.
i did some tests on the plugin
for instance
if i do get file
http://nodejs.org/dist/v0.10.26/node-v0.10.26.tar.gz
simultaneously on two sessions the plugin works fine
bare in mind that i also have cacheurl plugin enabled and nothing more
so
when i try for instance
http://r13---sn-4g57knl7.c.pack.google.com/edgedl/chrome/win/D097CE1C604D228F/33.0.1750.117_chrome_installer.exe?cms_redirect=yes&expire=1393887628&ip=185.33.115.252&ipbits=0&ir=1&ms=nvh&mt=1393873206&mv=m&sparams=expire,ip,ipbits&signature=64A0BC940DB3116CC8F229C3864D49167F91A827.2B36AC4D4DCB3F6CDDC9D3A8B7DF22E63AB7C947&key=cms1
which i already have it mapped to
http://pack.google.com/edgedl/chrome/win/D097CE1C604D228F/33.0.1750.117_chrome_installer.exe through cacheurl plugin
the collapsed_connection does not work. and the file is not collapsed on a single connection
much regards
Faysal Banna
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by Degreane <gi...@git.apache.org>.
Github user Degreane commented on the pull request:
https://github.com/apache/trafficserver/pull/53#issuecomment-36556450
Sir.
first of all i did git pull as u described .
it didn't compile the plugin with default compile methods then i went doing
tsxs -o collapsed_connection.so collapsed_connection.cc
afterwards copied collapsed_connection.so to /usr/local/libexec/trafficserver
as usual where my lib for traffic server resides
enabled the plugin as your README says
with the config example as u provided
the plugin loaded fine but then i got an error
[Mar 4 06:26:29.477] Server {0x2b242f2ca240} NOTE: cache clustering disabled
[Mar 4 06:26:29.482] Server {0x2b242f2ca240} NOTE: ip_allow.config updated, reloading
[Mar 4 06:26:29.485] Server {0x2b242f2ca240} NOTE: cache clustering disabled
[Mar 4 06:26:29.486] Server {0x2b242f2ca240} NOTE: logging initialized[3], logging_mode = 3
[Mar 4 06:26:29.486] Server {0x2b242f2ca240} NOTE: loading plugin '/usr/local/libexec/trafficserver/cacheurl.so'
[Mar 4 06:26:29.486] Server {0x2b242f2ca240} NOTE: loading plugin '/usr/local/libexec/trafficserver/collapsed_connection.so'
[Mar 4 06:26:29.487] Server {0x2b242f2ca240} FATAL: unable to load '/usr/local/libexec/trafficserver/collapsed_connection.so': /usr/local/libexec/trafficserver/collapsed_connection.so: undefined symbol: _Z18MurmurHash3_x86_32PKvijPv
hope this helps
much regards
Faysal Banna
degreane@gmail.com
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by Degreane <gi...@git.apache.org>.
Github user Degreane commented on the pull request:
https://github.com/apache/trafficserver/pull/53#issuecomment-40650993
Hi
Previously the patch would just install with no problems
but today i was trying to pull it in latest ATS git clone i got the stuff below
would it be fixed so we may be able to use it again ?
<code>
git pull https://github.com/yzlai/trafficserver TS-2604
remote: Counting objects: 24, done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 24 (delta 7), reused 15 (delta 3)
Unpacking objects: 100% (24/24), done.
From https://github.com/yzlai/trafficserver
* branch TS-2604 -> FETCH_HEAD
Auto-merging plugins/experimental/Makefile.am
Auto-merging configure.ac
CONFLICT (content): Merge conflict in configure.ac
Automatic merge failed; fix conflicts and then commit the result.
</code>
Much Regards
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-2604: collapsed connection plugin
Posted by Humbedooh <gi...@git.apache.org>.
Github user Humbedooh closed the pull request at:
https://github.com/apache/trafficserver/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---