[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9587: [SQL Lab] Lock result set controls to be always visible

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #9587:
URL: https://github.com/apache/incubator-superset/pull/9587#discussion_r411019995



##########
File path: superset-frontend/src/SqlLab/components/ResultSet.jsx
##########
@@ -143,48 +143,42 @@ export default class ResultSet extends React.PureComponent {
       }
       return (
         <div className="ResultSetControls">
-          <div className="clearfix">
-            <div className="pull-left">
-              <ButtonGroup>
-                {this.props.visualize && (
-                  <ExploreResultsButton
-                    query={this.props.query}
-                    database={this.props.database}
-                    actions={this.props.actions}
-                  />
-                )}
-                {this.props.csv && (
-                  <Button
-                    bsSize="small"
-                    href={'/superset/csv/' + this.props.query.id}
-                  >
-                    <i className="fa fa-file-text-o" /> {t('.CSV')}
-                  </Button>
-                )}
+          <div className="ResultSetButtons">
+            {this.props.visualize && (

Review comment:
       mostly indentation changes. the only change is the ResultSetButtons div




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org