[GitHub] [airflow] o-nikolas commented on a diff in pull request #32646: Add task log shipper feature to allow forwarding messages to task logs

["o-nikolas (via GitHub)" <gi...@apache.org>]

o-nikolas commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1276648588


##########
airflow/utils/log/file_task_handler.py:
##########
@@ -182,14 +183,20 @@ def set_context(self, ti: TaskInstance) -> None | SetContextPropagate:
         functionality is only used in unit testing.
 
         :param ti: task instance object
+        :param identifier: if set, adds suffix to log file. For use when shipping exceptional messages
+            to task logs from context other than task or trigger run

Review Comment:
   ```suggestion
               to task logs from a context other than task or trigger run
   ```



##########
airflow/config_templates/airflow_local_settings.py:
##########
@@ -171,6 +171,9 @@
     },
 }
 
+# Task log shipping from Airflow components like scheduler, executor, etc.
+TASK_LOG_SHIPPER_ENABLED = conf.getboolean("logging", "enable_task_log_shipper")

Review Comment:
   I know there's been some naming discussion already, but just to add my thoughts: ship/shipper is quite colloquial and might be jargon that folks in different contexts wouldn't understand. Maybe something like "transport", "export", "dispatch" (and they're related "...er" versions) might be a little more professional and clear?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org