[GitHub] [activemq-nms-amqp] cjwmorgan-sol edited a comment on issue #24: AMQNET-603: AmqpProvider shouldn't signal exception when connection is explicitly closed

[GitBox <gi...@apache.org>]

cjwmorgan-sol edited a comment on issue #24: AMQNET-603: AmqpProvider shouldn't signal exception when connection is explicitly closed
URL: https://github.com/apache/activemq-nms-amqp/pull/24#issuecomment-526773676
 
 
   > @Havret @cjwmorgan-sol anything else outstanding apart from README to be updated, before we try for a first cut release?
   
   @michaelandrepearce @Havret 
   Have you tried to run the unit tests on linux? I found anywhere between 4-7 unit tests would fail consistently. I could not get the tests to fail on windows and Helloworld worked on linux. As far as I know there is no platform specific code so I don't think it should block a release. It might be trying it out an a linux machine that isn't a virtualized or starved resource machine. :)
   Other then the readme I think its ready.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services