You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2019/12/26 10:04:00 UTC
[jira] [Commented] (AIRFLOW-6357) Graph UI nodes hightlight is
broken when task id contains dots
[ https://issues.apache.org/jira/browse/AIRFLOW-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17003559#comment-17003559 ]
ASF GitHub Bot commented on AIRFLOW-6357:
-----------------------------------------
Khrol commented on pull request #6904: [AIRFLOW-6357] Highlight nodes in Graph UI if task id contains dots
URL: https://github.com/apache/airflow/pull/6904
If task id contains dots:
graph?dag_id=daily_dag:1246 Uncaught TypeError: Cannot read property 'parentNode' of null
at graph?dag_id=daily_dag:1246
at Array.forEach (<anonymous>)
at highlight_nodes (graph?dag_id=daily_dag:1245)
at SVGGElement.<anonymous> (graph?dag_id=daily_dag:1253)
at SVGGElement.__onmouseover (d3.min.js:1)
https://stackoverflow.com/a/25942226/1849364 - some more context about the fix.
Make sure you have checked _all_ steps below.
### Jira
- [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-6357
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
The following DAG helps to reproduce the problem:
```python
with DAG(dag_id='hightlight_test', start_date=airflow.utils.dates.days_ago(2)) as dag:
t1 = DummyOperator(task_id='t1')
t2 = DummyOperator(task_id='t2.t2')
t3 = DummyOperator(task_id='t3.t3')
t1 >> t2
t2 >> t3
```
- [x] Here are some details about my PR, including screenshots of any UI changes:
After the fix:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
I don't know if we are able to cover it by UI tests.
### Commits
- [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Graph UI nodes hightlight is broken when task id contains dots
> --------------------------------------------------------------
>
> Key: AIRFLOW-6357
> URL: https://issues.apache.org/jira/browse/AIRFLOW-6357
> Project: Apache Airflow
> Issue Type: Bug
> Components: ui
> Affects Versions: 1.10.7
> Reporter: Igor Khrol
> Assignee: Igor Khrol
> Priority: Minor
>
> If task id contains a dot, Graph UI highlight is broken.
>
> ```
> with DAG(dag_id='hightlight_test', start_date=airflow.utils.dates.days_ago(2)) as dag:
> t1 = DummyOperator(task_id='t1')
> t2 = DummyOperator(task_id='t2.t2')
> t3 = DummyOperator(task_id='t3.t3')
> t1 >> t2
> t2 >> t3
> ```
>
> If you hightlight nodes in this DAG the following stacktrace is in JS console:
>
> graph?dag_id=daily_dag:1246 Uncaught TypeError: Cannot read property 'parentNode' of null
> at graph?dag_id=daily_dag:1246
> at Array.forEach (<anonymous>)
> at highlight_nodes (graph?dag_id=daily_dag:1245)
> at SVGGElement.<anonymous> (graph?dag_id=daily_dag:1253)
> at SVGGElement.__onmouseover (d3.min.js:1)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)