You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/04/17 21:14:15 UTC
[jira] Created: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
read repair of tombstones on columnfamilies and supercolumns
------------------------------------------------------------
Key: CASSANDRA-87
URL: https://issues.apache.org/jira/browse/CASSANDRA-87
Project: Cassandra
Issue Type: Bug
Reporter: Jonathan Ellis
Fix For: 0.3
existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis reassigned CASSANDRA-87:
---------------------------------------
Assignee: Jonathan Ellis
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702180#action_12702180 ]
Jonathan Ellis commented on CASSANDRA-87:
-----------------------------------------
going with rowOther and [row|cf]Composite, respectively
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702156#action_12702156 ]
Jun Rao commented on CASSANDRA-87:
----------------------------------
how about targetRow?
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702142#action_12702142 ]
Jun Rao commented on CASSANDRA-87:
----------------------------------
Patch looks fine to me.
It seems to me that arg to Row.repair should be rowNew, instead of rowOld.
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-87:
------------------------------------
Attachment: 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12701740#action_12701740 ]
Jonathan Ellis commented on CASSANDRA-87:
-----------------------------------------
02
use resolve (moved to CF from CFS) rather than duplicating code in repair to do the
same thing. this automatically gets us most of the way to handling tombstones in
read repair. the rest is minor tweaks to CF.diff and SC.diff. added tests.
01
clean up Read Repair code to use non-deprecated APIs
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-87:
------------------------------------
Attachment: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702153#action_12702153 ]
Jonathan Ellis commented on CASSANDRA-87:
-----------------------------------------
the idea was to suggest a difference between repair, where the row passed in should be incorporated into "this", and diff, where the row passed in is a superset of "this".
suggestions?
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-87) read repair of tombstones on
columnfamilies and supercolumns
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-87.
-------------------------------------
Resolution: Fixed
committed
> read repair of tombstones on columnfamilies and supercolumns
> ------------------------------------------------------------
>
> Key: CASSANDRA-87
> URL: https://issues.apache.org/jira/browse/CASSANDRA-87
> Project: Cassandra
> Issue Type: Bug
> Reporter: Jonathan Ellis
> Fix For: 0.3
>
> Attachments: 0001-clean-up-Read-Repair-code-to-use-non-deprecated-APIs.patch, 0002-use-resolve-moved-to-CF-from-CFS-rather-than-dupli.patch
>
>
> existing RR code only repairs column tombstones (since normally CF/SC do not have values associated w/ them directly).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.