You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/30 03:44:12 UTC
[GitHub] [incubator-dolphinscheduler] samz406 opened a new pull request
#1637: add service UT
samz406 opened a new pull request #1637: add service UT
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1637
**What is the purpose of the pull request**
For #1465 .
API service adds some test cases
**Brief change log**
**add Test class**
AccessTokenServiceTest.java
QueueServiceTest.java
MonitorServiceTest.java
SessionServiceTest.java
UsersServiceTest.java
TenantServiceTest.java
WorkerGroupServiceTest.java
AlertGroupServiceTest.java
ProjectServiceTest.java
**Add root pom.xml as follow**
```
<include>**/api/service/AccessTokenServiceTest.java</include> <include>**/api/service/QueueServiceTest.java</include>
<include>**/api/service/MonitorServiceTest.java</include> <include>**/api/service/SessionServiceTest.java</include>
<include>**/api/service/UsersServiceTest.java</include> <include>**/api/service/TenantServiceTest.java</include>
<include>**/api/service/WorkerGroupServiceTest.java</include>
<include>**/api/service/AlertGroupServiceTest.java</include> <include>**/api/service/ProjectServiceTest.java</include>
```
Verify this pull request
other
MonitorServiceTest.java need zk server.Test case temporary comments
由于MonitorServiceTest.java需要zk获取master和worker服务，单元测试暂时注释
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] dailidong merged pull request #1637:
add service UT
Posted by GitBox <gi...@apache.org>.
dailidong merged pull request #1637: add service UT
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1637:
add service UT
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1637: add service UT
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1637#issuecomment-569574854
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637?src=pr&el=h1) Report
> Merging [#1637](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/046d408154cc50d79ac4e70be65b54af4649c2d5?src=pr&el=desc) will **increase** coverage by `5.28%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1637 +/- ##
========================================
+ Coverage 8.11% 13.4% +5.28%
========================================
Files 282 282
Lines 13922 13924 +2
Branches 2255 2254 -1
========================================
+ Hits 1130 1866 +736
+ Misses 12674 11852 -822
- Partials 118 206 +88
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...inscheduler/alert/utils/EnterpriseWeChatUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9FbnRlcnByaXNlV2VDaGF0VXRpbHMuamF2YQ==) | `0% <0%> (ø)` | :arrow_up: |
| [...org/apache/dolphinscheduler/alert/AlertServer.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC9BbGVydFNlcnZlci5qYXZh) | `0% <0%> (ø)` | :arrow_up: |
| [...olphinscheduler/api/controller/BaseController.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvQmFzZUNvbnRyb2xsZXIuamF2YQ==) | `3.65% <0%> (+3.65%)` | :arrow_up: |
| [.../apache/dolphinscheduler/api/utils/CheckUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL0NoZWNrVXRpbHMuamF2YQ==) | `45.83% <0%> (+8.33%)` | :arrow_up: |
| [...e/dolphinscheduler/api/service/MonitorService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvTW9uaXRvclNlcnZpY2UuamF2YQ==) | `16.12% <0%> (+16.12%)` | :arrow_up: |
| [...rg/apache/dolphinscheduler/api/utils/PageInfo.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3V0aWxzL1BhZ2VJbmZvLmphdmE=) | `37.5% <0%> (+37.5%)` | :arrow_up: |
| [...e/dolphinscheduler/api/service/SessionService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvU2Vzc2lvblNlcnZpY2UuamF2YQ==) | `52.77% <0%> (+52.77%)` | :arrow_up: |
| [...ache/dolphinscheduler/api/service/BaseService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvQmFzZVNlcnZpY2UuamF2YQ==) | `55.55% <0%> (+55.55%)` | :arrow_up: |
| [...he/dolphinscheduler/api/service/TenantService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVGVuYW50U2VydmljZS5qYXZh) | `72.89% <0%> (+72.89%)` | :arrow_up: |
| [...che/dolphinscheduler/api/service/UsersService.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL3NlcnZpY2UvVXNlcnNTZXJ2aWNlLmphdmE=) | `73.57% <0%> (+73.57%)` | :arrow_up: |
| ... and [6 more](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637?src=pr&el=footer). Last update [046d408...4aff615](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1637?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services