[GitHub] [beam] kamrankoupayi commented on pull request #25056: Beam/sdks/io/gcp/java/healcare/hl7v2 io read

["kamrankoupayi (via GitHub)" <gi...@apache.org>]

kamrankoupayi commented on PR #25056:
URL: https://github.com/apache/beam/pull/25056#issuecomment-1423610423

   > Thanks, looks pretty good. Got a couple of minor comment.
   > 
   > Also, the added integration test has a warning:
   > 
   > https://ci-beam.apache.org/job/beam_PreCommit_Java_GCP_IO_Direct_Commit/1564/testReport/org.apache.beam.sdk.io.gcp.healthcare/HL7v2IOReadWriteIT/testHL7v2IOGetAllE2E/
   > 
   > ```
   > WARNING: Can't verify serialized elements of type HL7v2ReadParameter have well defined equals method. This may produce incorrect results on some PipelineRunner implementations
   > ```
   > 
   > Is this something need attention?
   
   Thank you for review and your comments.
   And yes that's important so I added the equal function for HL7v2ReadParameter class to address this warning. Thanks for catching.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org