You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2017/04/13 22:33:39 UTC

Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58438/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Bugs: AMBARI-20763
    https://issues.apache.org/jira/browse/AMBARI-20763


Repository: ambari


Description
-------

In 2.6, update the following YARN configs related to ATS:

- **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster initialization/creation based on host memory.
- **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation and/or (2). when a change is detected in value for 'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
   
  ats_heapsize = long(min(math.floor(host_mem/2), long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB


Diffs
-----

  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py fc32001 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml d04c3c5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 7881917 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 4250681 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 


Diff: https://reviews.apache.org/r/58438/diff/1/


Testing
-------

Yes, 

Python UTs added.
Tested on cluster.


Thanks,

Swapan Shridhar


Re: Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58438/#review172096
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py
Lines 253 (patched)
<https://reviews.apache.org/r/58438/#comment245173>

    Same comments, doc needs to be updated.
    
    Also, the Code Review title should say 3.0


- Alejandro Fernandez


On April 13, 2017, 11:08 p.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58438/
> -----------------------------------------------------------
> 
> (Updated April 13, 2017, 11:08 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20763
>     https://issues.apache.org/jira/browse/AMBARI-20763
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In 2.6, update the following YARN configs related to ATS:
> 
> - **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster initialization/creation based on host memory.
> - **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation and/or (2). when a change is detected in value for 'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
>    
>   ats_heapsize = long(min(math.floor(host_mem/2), long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py fc32001 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml d04c3c5 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 7881917 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 4250681 
>   ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 
> 
> 
> Diff: https://reviews.apache.org/r/58438/diff/2/
> 
> 
> Testing
> -------
> 
> Yes, 
> 
> Python UTs added.
> Tested on cluster.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>


Re: Review Request 58438: AMBARI-20763. Update YARN's ATS configs 'apptimelineserver_heapsize' and 'yarn.timeline-service.entity-group-fs-store.app-cache-size' logic in 2.6.

Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58438/
-----------------------------------------------------------

(Updated April 13, 2017, 11:08 p.m.)


Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.


Changes
-------

Updated 'display name' and 'description' for 'apptimelineserver_heapsize'


Bugs: AMBARI-20763
    https://issues.apache.org/jira/browse/AMBARI-20763


Repository: ambari


Description
-------

In 2.6, update the following YARN configs related to ATS:

- **'yarn.timeline-service.entity-group-fs-store.app-cache-size'** on cluster initialization/creation based on host memory.
- **'apptimelineserver_heapsize'** on : (1). cluster initialization/creation and/or (2). when a change is detected in value for 'yarn.timeline-service.entity-group-fs-store.app-cache-size', using formula:
   
  ats_heapsize = long(min(math.floor(host_mem/2), long(yarn_timeline_app_cache_size) * 500 + 3072))  // Value in MB


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/service_advisor.py fc32001 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/configuration/yarn-env.xml d04c3c5 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 7881917 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 4250681 
  ambari-server/src/test/python/stacks/2.6/common/test_stack_advisor.py 5bfa1a9 


Diff: https://reviews.apache.org/r/58438/diff/2/

Changes: https://reviews.apache.org/r/58438/diff/1-2/


Testing
-------

Yes, 

Python UTs added.
Tested on cluster.


Thanks,

Swapan Shridhar