You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/16 02:05:50 UTC

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19147: [WIP] Update test_np_large_array.py to use more meaningful variable names

Zha0q1 commented on a change in pull request #19147:
URL: https://github.com/apache/incubator-mxnet/pull/19147#discussion_r489117736



##########
File path: tests/nightly/test_np_large_array.py
##########
@@ -90,28 +90,28 @@ def test_softmax():
 
 @use_np
 def test_ones():
-    A = np.ones((INT_OVERFLOW, 2))
-    assert A.shape == (INT_OVERFLOW, 2)
-    assert A[0][0] == 1
+    data = np.ones((INT_OVERFLOW, 2))

Review comment:
       I think for generative ops maybe we can use `data`? For other ops I will definitely use `input` and `output`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org