You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/05/17 08:07:13 UTC

[GitHub] [incubator-superset] vnktsh opened a new issue #9821: In Table chart, when selecting a column to sort which is part of group by keys, the UI forces to chose an aggregate function and disables 'Save' button.

vnktsh opened a new issue #9821:
URL: https://github.com/apache/incubator-superset/issues/9821


   Allow to set default sort ordering by group by column in Table chart.
   
   ### Expected results
   When selecting a column to sort which is part of group by keys, the UI forces to chose an aggregate function and disables 'Save' button.
   
   ### Actual results
   Expected behaviour is to not to prompt for aggregate function and allow to chose just column and enable 'Save' option.
   
   #### Screenshots
   ![image](https://user-images.githubusercontent.com/6447905/82139069-ee0a1100-97ea-11ea-93e9-ebc6caafd268.png)
   
   In the above screenshot, I should be able to chose "filter_name" as my default sort order without choosing any aggregate function, so that when it is embedded in dashboard, the sort order is persisted.
   As shown, 'Save' button is disabled.
   
   
   #### How to reproduce the bug
   This is very trivial and easy to reproduce.
   1. Select any table for aggregation
   2. Group by few set of columns
   3. Set a metric column (chose any of the aggregate function)
   4. Now try to sort the resulting table by a column which are part of Step 2.
   5. UI forces to chose an aggregate function for this column and disables 'Save' button, even though this column is part of Group By keys.
   
   ### Environment
   - superset version: `0.36.0`
   - python version: default version from Dockerfile `ARG PY_VER=3.6.9'
   - node.js version: default version from docker compose file `image: node:10-jessie'
   - npm version: default version from docker compose file `image: node:10-jessie'
   
   ### Checklist
   - [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
   - [x] I have reproduced the issue with at least the latest released version of superset.
   - [x] I have checked the issue tracker for the same issue and I haven't found one similar.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] stale[bot] closed issue #9821: In Table chart, when selecting a column to sort which is part of group by keys, the UI forces to chose an aggregate function and disables 'Save' button.

Posted by GitBox <gi...@apache.org>.
stale[bot] closed issue #9821:
URL: https://github.com/apache/incubator-superset/issues/9821


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] stale[bot] commented on issue #9821: In Table chart, when selecting a column to sort which is part of group by keys, the UI forces to chose an aggregate function and disables 'Save' button.

Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9821:
URL: https://github.com/apache/incubator-superset/issues/9821#issuecomment-660435953


   This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org