You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/09/26 06:04:52 UTC
Review Request 62558: Restore scheduler benchmarks to working order
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62558/
-----------------------------------------------------------
Review request for Aurora and Stephan Erb.
Repository: aurora
Description
-------
The JMH plugin required an update after gradle >=4.0. Additionally, a privately-bound guice key was being used from the benchmark, leading to an error when starting the benchmark.
Diffs
-----
build.gradle 851bab52fd389bc9577a6938f646bb29bae06139
src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java ddbfd37d6b5273707ba8d4e5d92d55e6435509d4
Diff: https://reviews.apache.org/r/62558/diff/1/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 62558: Restore scheduler benchmarks to working
order
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62558/#review186276
-----------------------------------------------------------
Ship it!
Ship It!
- David McLaughlin
On Sept. 26, 2017, 6:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62558/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 6:04 a.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The JMH plugin required an update after gradle >=4.0. Additionally, a privately-bound guice key was being used from the benchmark, leading to an error when starting the benchmark.
>
>
> Diffs
> -----
>
> build.gradle 851bab52fd389bc9577a6938f646bb29bae06139
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java ddbfd37d6b5273707ba8d4e5d92d55e6435509d4
>
>
> Diff: https://reviews.apache.org/r/62558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62558: Restore scheduler benchmarks to working
order
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62558/#review186268
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Sept. 26, 2017, 8:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62558/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 8:04 a.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The JMH plugin required an update after gradle >=4.0. Additionally, a privately-bound guice key was being used from the benchmark, leading to an error when starting the benchmark.
>
>
> Diffs
> -----
>
> build.gradle 851bab52fd389bc9577a6938f646bb29bae06139
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java ddbfd37d6b5273707ba8d4e5d92d55e6435509d4
>
>
> Diff: https://reviews.apache.org/r/62558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62558: Restore scheduler benchmarks to working
order
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62558/#review186267
-----------------------------------------------------------
Thanks! I am currently working on the update to Thrift 0.10 and having the benchmarks working again comes in handy here.
- Stephan Erb
On Sept. 26, 2017, 8:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62558/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 8:04 a.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The JMH plugin required an update after gradle >=4.0. Additionally, a privately-bound guice key was being used from the benchmark, leading to an error when starting the benchmark.
>
>
> Diffs
> -----
>
> build.gradle 851bab52fd389bc9577a6938f646bb29bae06139
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java ddbfd37d6b5273707ba8d4e5d92d55e6435509d4
>
>
> Diff: https://reviews.apache.org/r/62558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62558: Restore scheduler benchmarks to working
order
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62558/#review186213
-----------------------------------------------------------
Ship it!
Master (0606369) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 26, 2017, 6:04 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62558/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2017, 6:04 a.m.)
>
>
> Review request for Aurora and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The JMH plugin required an update after gradle >=4.0. Additionally, a privately-bound guice key was being used from the benchmark, leading to an error when starting the benchmark.
>
>
> Diffs
> -----
>
> build.gradle 851bab52fd389bc9577a6938f646bb29bae06139
> src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java ddbfd37d6b5273707ba8d4e5d92d55e6435509d4
>
>
> Diff: https://reviews.apache.org/r/62558/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>