You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/08 04:21:54 UTC
[GitHub] [spark] dcoliversun opened a new pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
dcoliversun opened a new pull request #35758:
URL: https://github.com/apache/spark/pull/35758
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add braces with if,else,for,do and while statements.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Braces are used with if, else, for, do and while statements, even if the body contains only a single statement. Avoid using the following example:
```java
if (condition) statements;
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Unit test passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063575021
@HyukjinKwon
Thanks for your sharing. The information you provide can prove the value of my PR.
* [Oracle's Java code conventions](https://www.oracle.com/java/technologies/javase/codeconventions-contents.html)
* [Scala Control Structures](https://docs.scala-lang.org/style/control-structures.html)
It looks like this is necessary to add braces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063563057
Not sure. Scala actually encourages to remove that curly braces (https://docs.scala-lang.org/style/control-structures.html). To me it still sounds like unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1061408958
@dongjoon-hyun @martin-g
It would be good if you could take a look when you have time, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063567756
Java side actually follows Scala guide because Spark developers are used to Scala side:
> For Java code, Apache Spark follows [Oracle’s Java code conventions](http://www.oracle.com/technetwork/java/codeconvtoc-136057.html) and Scala guidelines below. The latter is preferred.
https://spark.apache.org/contributing.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063609808
> The latter is preferred.
Scala guide is preferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1062460450
> Hm, I don't think this is worthwhile. Either way with/without braces is fine to me honestly.
@HyukjinKwon
Hi. Code like the following is syntactically correct; but it is bug-prone
```java
if (condition) statements;
```
The problem is sooner or later you or someone else is going to need add a line to that if statement.
```java
if (condition) statements; statements;
```
The program has suddenly become buggy. Not everyone does when the buggy lines aren’t called out and pointed to as they are here. Even written like this, not everyone will see the bug immediately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063609902
I don't mind if other committers like this change. So I will defer to them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063568298
In addition, I think these changes are rejected from other projects time to time, e.g.) `https://github.com/pi-hole/AdminLTE/issues/1027`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1061913553
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yeikel commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
yeikel commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063464729
Relevant : https://rules.sonarsource.com/java/RSPEC-121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063556646
@cloud-fan It would be good if you could take a look when you have time, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun closed pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun closed pull request #35758:
URL: https://github.com/apache/spark/pull/35758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yeikel commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
yeikel commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063564777
> Not sure. Scala actually encourages to remove that curly braces (https://docs.scala-lang.org/style/control-structures.html). To me it still sounds like unnecessary
Many of the modified files in this diff are .java files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063607438
@HyukjinKwon Hi.
I remove curly braces from *if, else* statements. This PR only add curly braces with *if and while* statements, which follows Scala guide.
I think it's good to use curly braces to prevent bugs.
If you think it's unnecessary and should be rejected, I'm OK and close this PR. 😊
Thanks for your review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063660761
Sorry to bother you @HyukjinKwon @dongjoon-hyun @martin-g
And thanks for your work @HyukjinKwon @yeikel
This PR is useless and close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun edited a comment on pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun edited a comment on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063575021
@HyukjinKwon
Thanks for your sharing. The information you provide can prove the value of my PR.
* [Scala Control Structures](https://docs.scala-lang.org/style/control-structures.html)
It looks like this is necessary to add curly braces with *if and while* statements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun removed a comment on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun removed a comment on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1063556646
@cloud-fan It would be good if you could take a look when you have time, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35758:
URL: https://github.com/apache/spark/pull/35758#discussion_r823353187
##########
File path: common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java
##########
@@ -134,8 +134,12 @@ public StoreVersion(@JsonProperty("major") int major, @JsonProperty("minor") int
@Override
public boolean equals(Object o) {
- if (this == o) return true;
Review comment:
you know what, these code are generated by IntelliJ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dcoliversun commented on a change in pull request #35758: [SPARK-38439][CORE][SQL] add curly braces with if, for and while statements
Posted by GitBox <gi...@apache.org>.
dcoliversun commented on a change in pull request #35758:
URL: https://github.com/apache/spark/pull/35758#discussion_r823354449
##########
File path: common/network-common/src/main/java/org/apache/spark/network/util/LevelDBProvider.java
##########
@@ -134,8 +134,12 @@ public StoreVersion(@JsonProperty("major") int major, @JsonProperty("minor") int
@Override
public boolean equals(Object o) {
- if (this == o) return true;
Review comment:
I don't know about these. Sorry to bother you too. Please ignore this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35758: [SPARK-38439][CORE][SQL] add braces with if,else,for,do and while statements
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35758:
URL: https://github.com/apache/spark/pull/35758#issuecomment-1061788212
Hm, I don't think this is worthwhile. Either way with/without braces is fine to me honestly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org