You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/22 19:26:37 UTC
[GitHub] [nifi-registry] pvillard31 opened a new pull request #316: NIFIREG-441 - Add test data source factory for Postgres 12 & 13
pvillard31 opened a new pull request #316:
URL: https://github.com/apache/nifi-registry/pull/316
Run tests with:
````
mvn verify -Dspring.profiles.active=postgres-12
mvn verify -Dspring.profiles.active=postgres-13
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] pvillard31 commented on pull request #316: NIFIREG-441 - Add test data source factory for Postgres 12 & 13
Posted by GitBox <gi...@apache.org>.
pvillard31 commented on pull request #316:
URL: https://github.com/apache/nifi-registry/pull/316#issuecomment-786097546
I just pushed a commit to update the dependency version for testcontainers. Thanks for the review @bbende !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] bbende merged pull request #316: NIFIREG-441 - Add test data source factory for Postgres 12 & 13
Posted by GitBox <gi...@apache.org>.
bbende merged pull request #316:
URL: https://github.com/apache/nifi-registry/pull/316
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] bbende commented on pull request #316: NIFIREG-441 - Add test data source factory for Postgres 12 & 13
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #316:
URL: https://github.com/apache/nifi-registry/pull/316#issuecomment-785928854
Looks good, will merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] bbende commented on pull request #316: NIFIREG-441 - Add test data source factory for Postgres 12 & 13
Posted by GitBox <gi...@apache.org>.
bbende commented on pull request #316:
URL: https://github.com/apache/nifi-registry/pull/316#issuecomment-786155749
Thanks, tests passing locally now, will merge
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-registry] bbende edited a comment on pull request #316: NIFIREG-441 - Add test data source factory for Postgres 12 & 13
Posted by GitBox <gi...@apache.org>.
bbende edited a comment on pull request #316:
URL: https://github.com/apache/nifi-registry/pull/316#issuecomment-785928854
Tested this out locally and happened to be on a new laptop where I had never run these IT tests before and got a failure:
{"message":"No such image: quay.io/testcontainers/ryuk:0.2.3"}
I'm guessing maybe I always had this image cached before. Found this discussion which mentioned how testcontainers 1.15.1 would have a fix for something similar:
https://github.com/testcontainers/testcontainers-java/issues/3574
Everything passed for me using that version, so can we update that in the root pom?
Also, any reason to not include postgres 12 and 13 in the test-all-dbs profile?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org