You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/04/23 11:03:42 UTC
[GitHub] [maven-site] elharo opened a new pull request, #412: spotless fix
elharo opened a new pull request, #412:
URL: https://github.com/apache/maven-site/pull/412
somebody must have updated without running `mvn test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo merged pull request #412: spotless fix
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo merged PR #412:
URL: https://github.com/apache/maven-site/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] slawekjaranowski commented on a diff in pull request #412: spotless fix
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #412:
URL: https://github.com/apache/maven-site/pull/412#discussion_r1174558948
##########
pom.xml:
##########
@@ -55,7 +55,8 @@
<properties>
<maven.site.path>maven-site</maven.site.path>
- <project.build.outputTimestamp>x</project.build.outputTimestamp><!-- disable Reproducible Builds that makes the site build time fixed at last release time -->
+ <project.build.outputTimestamp>x</project.build.outputTimestamp>
+ <!-- disable Reproducible Builds that makes the site build time fixed at last release time -->
Review Comment:
should be one line upper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-site] elharo commented on a diff in pull request #412: spotless fix
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #412:
URL: https://github.com/apache/maven-site/pull/412#discussion_r1174569591
##########
pom.xml:
##########
@@ -55,7 +55,8 @@
<properties>
<maven.site.path>maven-site</maven.site.path>
- <project.build.outputTimestamp>x</project.build.outputTimestamp><!-- disable Reproducible Builds that makes the site build time fixed at last release time -->
+ <project.build.outputTimestamp>x</project.build.outputTimestamp>
+ <!-- disable Reproducible Builds that makes the site build time fixed at last release time -->
Review Comment:
I'm not sure what you mean. In any case, this is exactly how spotless changed the existing file, nothing else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org