You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/04/17 12:47:59 UTC

[GitHub] [kyuubi] pan3793 opened a new pull request, #4723: [KYUUBI #4367][DOCS][FOLLOWUP] Kyuubi requires Flink 1.16/1.17

pan3793 opened a new pull request, #4723:
URL: https://github.com/apache/kyuubi/pull/4723

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   Kyuubi requires Flink 1.16/1.17 now
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.readthedocs.io/en/master/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] link3280 commented on pull request #4723: [KYUUBI #4367][DOCS][FOLLOWUP] Kyuubi requires Flink 1.16/1.17

Posted by "link3280 (via GitHub)" <gi...@apache.org>.
link3280 commented on PR #4723:
URL: https://github.com/apache/kyuubi/pull/4723#issuecomment-1511373336

   LGTM.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] pan3793 commented on pull request #4723: [KYUUBI #4367][DOCS][FOLLOWUP] Kyuubi requires Flink 1.16/1.17

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4723:
URL: https://github.com/apache/kyuubi/pull/4723#issuecomment-1511274720

   cc @link3280 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] pan3793 closed pull request #4723: [KYUUBI #4367][DOCS][FOLLOWUP] Kyuubi requires Flink 1.16/1.17

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #4723: [KYUUBI #4367][DOCS][FOLLOWUP] Kyuubi requires Flink 1.16/1.17
URL: https://github.com/apache/kyuubi/pull/4723


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] codecov-commenter commented on pull request #4723: [KYUUBI #4367][DOCS][FOLLOWUP] Kyuubi requires Flink 1.16/1.17

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4723:
URL: https://github.com/apache/kyuubi/pull/4723#issuecomment-1511449803

   ## [Codecov](https://codecov.io/gh/apache/kyuubi/pull/4723?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4723](https://codecov.io/gh/apache/kyuubi/pull/4723?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1e64dcb) into [master](https://codecov.io/gh/apache/kyuubi/commit/b3dc4f8e3050b5341b34cb9f5f4f704d8b2c0fdf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b3dc4f8) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master    #4723   +/-   ##
   =========================================
     Coverage     58.07%   58.08%           
     Complexity       13       13           
   =========================================
     Files           580      580           
     Lines         32273    32273           
     Branches       4310     4310           
   =========================================
   + Hits          18742    18745    +3     
   + Misses        11731    11726    -5     
   - Partials       1800     1802    +2     
   ```
   
   
   [see 11 files with indirect coverage changes](https://codecov.io/gh/apache/kyuubi/pull/4723/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [kyuubi] pan3793 commented on pull request #4723: [KYUUBI #4367][DOCS][FOLLOWUP] Kyuubi requires Flink 1.16/1.17

Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #4723:
URL: https://github.com/apache/kyuubi/pull/4723#issuecomment-1511539606

   Thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org