You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "Dante-dan (via GitHub)" <gi...@apache.org> on 2026/09/12 07:37:15 UTC

[PR] fix(scheduled-task): preserve snoozed occurrence on edits [maka]

Dante-dan opened a new pull request, #5226:
URL: https://github.com/apache/maka/pull/5226

   ## Summary
   
   Keep schedule edits distinct from metadata-only edits so renaming a snoozed recurring task preserves both its recurrence anchor and its pending snoozed occurrence.
   
   The edit form now omits the schedule patch when its schedule fields are unchanged. Storage preserves a future pending occurrence for metadata-only updates, while explicit schedule changes and overdue occurrences continue to recompute normally.
   
   Fixes #5221
   
   ## Verification
   
   - `npm run lint`
   - `npm run format:check`
   - `npm --workspace @maka/storage run typecheck`
   - `npm --workspace @maka/ui run typecheck`
   - `npm --workspace @maka/storage run build`
   - `npm --workspace @maka/ui run build`
   - Scheduled-task storage regression suite: 13/13 passed
   - UI scheduled-task regression tests: 4/4 passed
   - Cleanly compiled UI suite: 422/422 passed
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: Codex implemented the schedule-update fix and added the targeted regression coverage.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [x] Yes — described under Summary above
   - [ ] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(scheduled-task): preserve snoozed occurrence on edits [maka]

Posted by "me2seeks (via GitHub)" <gi...@apache.org>.
me2seeks merged PR #5226:
URL: https://github.com/apache/maka/pull/5226


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] fix(scheduled-task): preserve snoozed occurrence on edits [maka]

Posted by "Dante-dan (via GitHub)" <gi...@apache.org>.
Dante-dan commented on PR #5226:
URL: https://github.com/apache/maka/pull/5226#issuecomment-5644953830

   Addressed the pause/resume gap from the review in commit `1d1595ccadbaf7066eaa41a0dd54bcc1daebe255`.
   
   - Pausing now retains the pending `nextFireAt`; the existing active-status check still prevents paused tasks from firing.
   - Resuming reuses that pending occurrence while it is still in the future, and recomputes from the recurrence after it has elapsed.
   - Metadata edits while paused preserve the pending occurrence; an explicit schedule edit still discards and recomputes it.
   
   Validation passed on this commit: `@maka/core` and `@maka/storage` builds, the scheduled-task core suite (16/16), targeted Biome lint/format checks, and `git diff --check`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org