[GitHub] [kafka] dengziming commented on a diff in pull request #11784: KAFKA-13228; Ensure ApiVersionRequest is properly handled KRaft co-resident mode

[GitBox <gi...@apache.org>]

dengziming commented on code in PR #11784:
URL: https://github.com/apache/kafka/pull/11784#discussion_r911578503


##########
core/src/main/scala/kafka/server/KafkaServer.scala:
##########
@@ -309,20 +312,28 @@ class KafkaServer(
         socketServer = new SocketServer(config, metrics, time, credentialProvider, apiVersionManager)
 
         // Start alter partition manager based on the IBP version
-        alterIsrManager = if (config.interBrokerProtocolVersion.isAlterPartitionSupported) {
+        alterPartitionManager = if (config.interBrokerProtocolVersion.isAlterPartitionSupported) {
+          val alterPartitionChannelManager = BrokerToControllerChannelManager(

Review Comment:
   I guess we create `BrokerToControllerChannelManager` in `BrokerServer` because we want to consolidate these channel to use only one, https://github.com/apache/kafka/pull/10135#discussion_r577322703
   but it's it's still early to consolidate channel now so I moved it to `AlterPartitionManager.apply` as you suggested.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org