You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Rakesh Gupta <ra...@gmail.com> on 2024/10/18 13:57:18 UTC
Review Request 75235: RANGER-4964: Issue with x_trx_log_IDX_trx_id Index in x_trx_log Table, causing patch failure
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75235/
-----------------------------------------------------------
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and sanket shelar.
Bugs: RANGER-4964
https://issues.apache.org/jira/browse/RANGER-4964
Repository: ranger
Description
-------
The issue occurred because the previous patch(RANGER-4809) failed to verify if the x_trx_log table existed before modifying the x_trx_log_IDX_trx_id index, which could result in errors. A table existence check needs to be added to the patch.
Diffs
-----
security-admin/db/mysql/patches/074-create-index-for-x_trx_log.sql 9a8f3c0d2
security-admin/db/oracle/patches/068-create-index-for-x_trx_log.sql 1ef726b53
security-admin/db/sqlanywhere/patches/068-create-index-for-x_trx_log.sql ae76a6de9
security-admin/db/sqlserver/patches/068-create-index-for-x_trx_log.sql 3efb9eebb
Diff: https://reviews.apache.org/r/75235/diff/1/
Testing
-------
Verified that the patch correctly checks for the existence of the x_trx_log table before attempting to modify the x_trx_log_IDX_trx_id index. It executes successfully without errors, even when the table does not exist.
Thanks,
Rakesh Gupta
Re: Review Request 75235: RANGER-4964: Issue with x_trx_log_IDX_trx_id Index in x_trx_log Table, causing patch failure
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75235/#review226984
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 18, 2024, 1:57 p.m., Rakesh Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75235/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2024, 1:57 p.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and sanket shelar.
>
>
> Bugs: RANGER-4964
> https://issues.apache.org/jira/browse/RANGER-4964
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The issue occurred because the previous patch(RANGER-4809) failed to verify if the x_trx_log table existed before modifying the x_trx_log_IDX_trx_id index, which could result in errors. A table existence check needs to be added to the patch.
>
>
> Diffs
> -----
>
> security-admin/db/mysql/patches/074-create-index-for-x_trx_log.sql 9a8f3c0d2
> security-admin/db/oracle/patches/068-create-index-for-x_trx_log.sql 1ef726b53
> security-admin/db/sqlanywhere/patches/068-create-index-for-x_trx_log.sql ae76a6de9
> security-admin/db/sqlserver/patches/068-create-index-for-x_trx_log.sql 3efb9eebb
>
>
> Diff: https://reviews.apache.org/r/75235/diff/1/
>
>
> Testing
> -------
>
> Verified that the patch correctly checks for the existence of the x_trx_log table before attempting to modify the x_trx_log_IDX_trx_id index. It executes successfully without errors, even when the table does not exist.
>
>
> Thanks,
>
> Rakesh Gupta
>
>
Re: Review Request 75235: RANGER-4964: Issue with x_trx_log_IDX_trx_id Index in x_trx_log Table, causing patch failure
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75235/#review226993
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 23, 2024, 11:54 a.m., Rakesh Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75235/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2024, 11:54 a.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and sanket shelar.
>
>
> Bugs: RANGER-4964
> https://issues.apache.org/jira/browse/RANGER-4964
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The issue occurred because the previous patch(RANGER-4809) failed to verify if the x_trx_log table existed before modifying the x_trx_log_IDX_trx_id index, which could result in errors. A table existence check needs to be added to the patch.
>
>
> Diffs
> -----
>
> security-admin/db/mysql/patches/074-create-index-for-x_trx_log.sql 9a8f3c0d2
> security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 551660ab4
> security-admin/db/oracle/patches/067-create-x_trx_log_v2.sql
> security-admin/db/oracle/patches/068-create-index-for-x_trx_log.sql 1ef726b53
> security-admin/db/postgres/patches/074-create-index-for-x_trx_log.sql 34cf77ccc
> security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 792fffd8d
> security-admin/db/sqlanywhere/patches/067-create-x_trx_log_v2.sql
> security-admin/db/sqlanywhere/patches/068-create-index-for-x_trx_log.sql ae76a6de9
> security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql eccf7f46f
> security-admin/db/sqlserver/patches/067-create-x_trx_log_v2.sql
> security-admin/db/sqlserver/patches/068-create-index-for-x_trx_log.sql 3efb9eebb
>
>
> Diff: https://reviews.apache.org/r/75235/diff/3/
>
>
> Testing
> -------
>
> Verified that the patch correctly checks for the existence of the x_trx_log table before attempting to modify the x_trx_log_IDX_trx_id index. It executes successfully without errors, even when the table does not exist.
>
>
> Thanks,
>
> Rakesh Gupta
>
>
Re: Review Request 75235: RANGER-4964: Issue with x_trx_log_IDX_trx_id Index in x_trx_log Table, causing patch failure
Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75235/
-----------------------------------------------------------
(Updated Oct. 23, 2024, 11:54 a.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and sanket shelar.
Bugs: RANGER-4964
https://issues.apache.org/jira/browse/RANGER-4964
Repository: ranger
Description
-------
The issue occurred because the previous patch(RANGER-4809) failed to verify if the x_trx_log table existed before modifying the x_trx_log_IDX_trx_id index, which could result in errors. A table existence check needs to be added to the patch.
Diffs (updated)
-----
security-admin/db/mysql/patches/074-create-index-for-x_trx_log.sql 9a8f3c0d2
security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql 551660ab4
security-admin/db/oracle/patches/067-create-x_trx_log_v2.sql
security-admin/db/oracle/patches/068-create-index-for-x_trx_log.sql 1ef726b53
security-admin/db/postgres/patches/074-create-index-for-x_trx_log.sql 34cf77ccc
security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql 792fffd8d
security-admin/db/sqlanywhere/patches/067-create-x_trx_log_v2.sql
security-admin/db/sqlanywhere/patches/068-create-index-for-x_trx_log.sql ae76a6de9
security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql eccf7f46f
security-admin/db/sqlserver/patches/067-create-x_trx_log_v2.sql
security-admin/db/sqlserver/patches/068-create-index-for-x_trx_log.sql 3efb9eebb
Diff: https://reviews.apache.org/r/75235/diff/3/
Changes: https://reviews.apache.org/r/75235/diff/2-3/
Testing
-------
Verified that the patch correctly checks for the existence of the x_trx_log table before attempting to modify the x_trx_log_IDX_trx_id index. It executes successfully without errors, even when the table does not exist.
Thanks,
Rakesh Gupta
Re: Review Request 75235: RANGER-4964: Issue with x_trx_log_IDX_trx_id Index in x_trx_log Table, causing patch failure
Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75235/
-----------------------------------------------------------
(Updated Oct. 21, 2024, 10:17 a.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Madhan Neethiraj, Mehul Parikh, and sanket shelar.
Bugs: RANGER-4964
https://issues.apache.org/jira/browse/RANGER-4964
Repository: ranger
Description
-------
The issue occurred because the previous patch(RANGER-4809) failed to verify if the x_trx_log table existed before modifying the x_trx_log_IDX_trx_id index, which could result in errors. A table existence check needs to be added to the patch.
Diffs (updated)
-----
security-admin/db/mysql/patches/074-create-index-for-x_trx_log.sql 9a8f3c0d2
security-admin/db/oracle/patches/068-create-index-for-x_trx_log.sql 1ef726b53
security-admin/db/postgres/patches/074-create-index-for-x_trx_log.sql 34cf77ccc
security-admin/db/sqlanywhere/patches/068-create-index-for-x_trx_log.sql ae76a6de9
security-admin/db/sqlserver/patches/068-create-index-for-x_trx_log.sql 3efb9eebb
Diff: https://reviews.apache.org/r/75235/diff/2/
Changes: https://reviews.apache.org/r/75235/diff/1-2/
Testing
-------
Verified that the patch correctly checks for the existence of the x_trx_log table before attempting to modify the x_trx_log_IDX_trx_id index. It executes successfully without errors, even when the table does not exist.
Thanks,
Rakesh Gupta