You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2022/02/11 09:24:03 UTC
[GitHub] [jackrabbit-oak] AngelaFabregues commented on a change in pull request #490: Oak 9686
AngelaFabregues commented on a change in pull request #490:
URL: https://github.com/apache/jackrabbit-oak/pull/490#discussion_r804476525
##########
File path: oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java
##########
@@ -108,11 +121,25 @@ public RestHighLevelClient getClient() {
Header[] headers = new Header[]{new BasicHeader("Authorization", "ApiKey " + apiKeyAuth)};
builder.setDefaultHeaders(headers);
}
- client = new RestHighLevelClient(builder);
+ hlClient = new RestHighLevelClient(builder);
Review comment:
I don't see this case as possible. I trust you and I assume it is a protective strategy to implement the code. I will try to understand and follow.
What I would like to assess beforehand is whether we are even contemplating the option of merging the code before it the client migration (recoding) has been completed. If so, yes we should be protective and I should put more attention on it.
##########
File path: oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticConnection.java
##########
@@ -108,11 +121,25 @@ public RestHighLevelClient getClient() {
Header[] headers = new Header[]{new BasicHeader("Authorization", "ApiKey " + apiKeyAuth)};
builder.setDefaultHeaders(headers);
}
- client = new RestHighLevelClient(builder);
+ hlClient = new RestHighLevelClient(builder);
Review comment:
I don't see this case as possible. I trust you and I assume it is a protective strategy to implement the code. I will try to understand and follow.
What I would like to assess beforehand is whether we are even contemplating the option of merging the code before it the client migration (recoding) has been completed. If so, yes we should be protective and I should put more attention to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org