[jira] [Commented] (SCB-444) try to optimize autodiscovery function

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421885#comment-16421885 ] 

ASF GitHub Bot commented on SCB-444:
------------------------------------

yangbor commented on a change in pull request #630: [SCB-444]try to optimize autoDiscovery function
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/630#discussion_r178479546
 
 

 ##########
 File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/client/http/ServiceRegistryClientImpl.java
 ##########
 @@ -98,7 +98,7 @@ private void retry(RequestContext requestContext, Handler<RestResponse> response
       HttpClientResponse response = restResponse.getResponse();
 
 Review comment:
   Duplicated code piece for retry, extract it as a method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> try to optimize autodiscovery function
> --------------------------------------
>
>                 Key: SCB-444
>                 URL: https://issues.apache.org/jira/browse/SCB-444
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Java-Chassis
>    Affects Versions: java-chassis-1.0.0-m2
>            Reporter: WeiChao
>            Assignee: TaoMeng
>            Priority: Minor
>             Fix For: java-chassis-1.0.0-m2
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)