Re: [I] [CI][Docs] Docs preview jobs failing due to package not found [arrow]

["hiroyuki-sato (via GitHub)" <gi...@apache.org>]

hiroyuki-sato commented on issue #46673:
URL: https://github.com/apache/arrow/issues/46673#issuecomment-2930510661

   Hello, @AlenkaF 
   
   It seems that this failure relates to my commit in #46527.
   
   I quoted `${INSTALL_ARGS}` like `"${INSTALL_ARGS}"`.
   https://github.com/apache/arrow/blob/main/ci/scripts/r_build.sh#L45
   
   As the result, 
   
   Before: `R CMD INSTALL arrow_20.0.0.9000.tar.gz`
   After: `R CMD INSTALL '' arrow_20.0.0.9000.tar.gz` 
   
   
   ```diff
   -    PKG_CONFIG_PATH=${ARROW_HOME}/lib/pkgconfig:${PKG_CONFIG_PATH} \
   -      ${R_BIN} CMD INSTALL ${INSTALL_ARGS} arrow*.tar.gz
   +    PKG_CONFIG_PATH="${ARROW_HOME}/lib/pkgconfig:${PKG_CONFIG_PATH}" \
   +      "${R_BIN}" CMD INSTALL "${INSTALL_ARGS}" arrow*.tar.gz
   ```
   
   What do you think to set default option like 
   
   ```
   INSTALL_ARGS="${INSTALL_ARGS:---with-keep.source --no-multiarch}"
   ```
   
   If this option set,
   
   This command will be
   
   * without `INSTALL_ARGS`: `R CMD INSTALL ---with-keep.source --no-multiarch arrow_20.0.0.9000.tar.gz`
   * with `INSTALL_ARGS`: `R CMD INSTALL %REPLACE_NEW_INSTALL_ARGS% arrow_20.0.0.9000.tar.gz`
   
   I don't familiar R. It asked ChatGPT `---with-keep.source --no-multiarch` is safe.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org