You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Julian Hyde (JIRA)" <ji...@apache.org> on 2017/03/04 21:12:45 UTC

[jira] [Resolved] (CALCITE-1668) RexUtil.simplify handle literal comparison simplification

     [ https://issues.apache.org/jira/browse/CALCITE-1668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Hyde resolved CALCITE-1668.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.12.0

Fixed in http://git-wip-us.apache.org/repos/asf/calcite/commit/255cd96a. [~risdenk], Thanks for your PR! I refactored your logic a little, combining it with the logic added for CALCITE-1638.

> RexUtil.simplify handle literal comparison simplification
> ---------------------------------------------------------
>
>                 Key: CALCITE-1668
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1668
>             Project: Calcite
>          Issue Type: Improvement
>          Components: core
>            Reporter: Kevin Risden
>            Assignee: Julian Hyde
>            Priority: Minor
>             Fix For: 1.12.0
>
>
> From the calcite-dev mailing list:
> Calcite doesn't seem to optimize away the literal comparison literal case
> with RexUtil.simplify. In my understanding any literal comparison literal
> results in a simple TRUE/FALSE result.
> I'm not sure this is valid in the general case, but I put together a simple
> example of doing this on the RexUtil simplifyCall.
> https://github.com/apache/calcite/pull/376
> Reference:
> http://mail-archives.apache.org/mod_mbox/calcite-dev/201702.mbox/%3CCAJU9nmidm%3DiXNG46YhSthXaBG0CGfmtPraxU9MxEOxnCTTLa_A%40mail.gmail.com%3E



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)