You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@texera.apache.org by GitBox <gi...@apache.org> on 2026/10/21 16:48:30 UTC
[GH] (texera/gh-readonly-queue/main/pr-9027-620a9f5ea493feb23d10562e5d54341f3d6b8753): Workflow run "Required Checks" is working again!
The GitHub Actions job "Required Checks" on texera.git/gh-readonly-queue/main/pr-9027-620a9f5ea493feb23d10562e5d54341f3d6b8753 has succeeded.
Run started by GitHub user aglinxinyuan (triggered by aglinxinyuan).
Head commit for run:
4d56cb524b9bb2418f5f68652cc4376971e503ec / Xinyuan Lin <xi...@uci.edu>
refactor(frontend): remove the dead admin Gmail stylesheet (#9027)
### What changes were proposed in this PR?
Deletes `admin-gmail.component.scss` and its `styleUrls` entry in
`admin-gmail.component.ts`. **−27 lines.** There is no behaviour change.
The stylesheet's only rule is `.form { ... }`. The component uses
emulated encapsulation, so the rule can only match an element in its own
template, and that template has no element with class `form`. The `<form
nz-form>` element doesn't match: `.form` is a class selector, and
`NzFormDirective` adds only `ant-form*` classes. Nothing else references
the file (`angular.json` styles, `@use`, `@import`). With no styles
left, Angular compiles the component without view emulation, so the
rendered DOM only loses the generated `_ngcontent` attributes.
### History
| | |
| --- | --- |
| **Introduced by** | #2027 (2023-10-11), "Introduce Email Notification
System". It copied `.form` from the login stylesheet into the new
component |
| **Usage removed by** | **never used**. No version of the Gmail
template has had a `form` class |
It has never applied, in the three years since it was added.
### Any related issues, documentation, discussions?
Closes #9024
### How was this PR tested?
No new tests; the spec never referenced the stylesheet.
From `frontend/`:
- `npx ng test --watch=false
--include='**/admin-gmail.component.spec.ts'`: 10 tests, all pass. No
other spec renders the component.
- `yarn format:ci`: clean.
- `npx ng build`: success.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5.5)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Report URL: https://github.com/apache/texera/actions/runs/39567472194
With regards,
GitHub Actions via GitBox