You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by sureshanaparti <gi...@git.apache.org> on 2016/12/29 12:02:40 UTC

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

GitHub user sureshanaparti opened a pull request:

    https://github.com/apache/cloudstack/pull/1878

    CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.

    Problem:
    [VMware] RVRs have mismatching MAC addresses for extra public NICs.
    
    Root Cause:
    MAC addresses for extra public NICs were assigned randomly for the routers. Network Orchestrator is unaware of the extra NICs info of the peer router as they are not persisted in the cloud database and so peer router MAC addresses info is not at all considered in case of RVR when assigning MAC addresses for extra public NICs.
    
    Solution:
    When RVR is enabled and Peer Router is available, get the MAC addresses of the extra public NICs from the Peer Router and set them to the router.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9717

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1878.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1878
    
----
commit 3da9416ecfea0e8177b3985dec7dce686dc8c9c9
Author: Suresh Kumar Anaparti <su...@accelerite.com>
Date:   2016-12-29T11:54:42Z

    CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC addresses for extra public NICs.
    Fix: When RVR is enabled and Peer Router is available, get the MAC addresses of the extra public NICs from the Peer Router and set them to the router.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1878#discussion_r105573097
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ---
    @@ -2071,6 +2120,14 @@ protected StartAnswer execute(StartCommand cmd) {
             }
         }
     
    +    private void replaceNicsMacSequenceInBootArgs(String oldMacSequence, String newMacSequence, VirtualMachineTO vmSpec) {
    +        String bootArgs = vmSpec.getBootArgs();
    +        if (!StringUtils.isEmpty(bootArgs) && !StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
    +            //Update boot args with the new nic mac addresses
    --- End diff --
    
    @rafaelweingartner Moved the comment to the method documentation part. Testcase added.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @rafaelweingartner Updated the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @rafaelweingartner Thanks for reviewing, will work on the changes suggested.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @sureshanaparti I see in vCenter any deployment of an RVR with a duplicate MAC, failing with a vCenter error regarding a duplicate MAC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1878#discussion_r105676576
  
    --- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
    @@ -302,4 +309,17 @@ public int countNicsForStartingVms(long networkId) {
             List<Integer> results = customSearch(sc, null);
             return results.get(0);
         }
    +
    +    @Override
    +    public Long getPeerRouterId(String publicMacAddress, final long routerId) {
    +        final SearchCriteria<NicVO> sc = PeerRouterSearch.create();
    +        sc.setParameters("instanceId", routerId);
    +        sc.setParameters("macAddress", publicMacAddress);
    +        sc.setParameters("vmType", VirtualMachine.Type.DomainRouter);
    +        NicVO nicVo = findOneBy(sc);
    +        if (nicVo != null) {
    +            return (new Long(nicVo.getInstanceId()));
    --- End diff --
    
    Let the auto-boxing and auto-unboxing do this for you.
    When you do this manually the pool of String/numbers of java will not be used.
    You just need to return `nicVo.getInstanceId()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @sureshanaparti why do the mac addresses need to be the same on both routers? We're also executing arpings to update our neighbours. Networking wise there is no need for them to be the same. I've seen it on other parts of the code as well and I really wonder why we do this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    Hi @sureshanaparti 
    Would you mind extracting the code at lines 1967-1972 to a specific method? Then, it allows you to write test cases for the newly created method and proper documentation of the method behaviors?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-519


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @borisstoyanov Can you please run trillian tests for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1878#discussion_r102226833
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ---
    @@ -2071,6 +2120,14 @@ protected StartAnswer execute(StartCommand cmd) {
             }
         }
     
    +    private void replaceNicsMacSequenceInBootArgs(String oldMacSequence, String newMacSequence, VirtualMachineTO vmSpec) {
    +        String bootArgs = vmSpec.getBootArgs();
    +        if (!StringUtils.isEmpty(bootArgs) && !StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
    +            //Update boot args with the new nic mac addresses
    --- End diff --
    
    What about moving this comment to the method documentation?
    Also, how do you feel about test cases? The method is pretty simple and it will not be hard to write some unit test for it.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @sureshanaparti Thanks for the info!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @remibergsma Same MAC for RVR has been re-introducted as part of [CLOUDSTACK-985](https://issues.apache.org/jira/browse/CLOUDSTACK-985). It confirms that peer NICs of RVRs should have same MAC addresses. Only default public NIC was configured with same MAC. For VMware, there exists additional public NICs which were not configured with same MAC addresses.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1878#discussion_r105678507
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ---
    @@ -1928,6 +1929,54 @@ protected StartAnswer execute(StartCommand cmd) {
                 VirtualDevice nic;
                 int nicMask = 0;
                 int nicCount = 0;
    +
    +            if (vmSpec.getType() == VirtualMachine.Type.DomainRouter) {
    +                int extraPublicNics = mgr.getRouterExtraPublicNics();
    +                if (extraPublicNics > 0 && vmSpec.getDetails().containsKey("PeerRouterInstanceName")) {
    +                    //Set identical MAC address for RvR on extra public interfaces
    +                    String peerRouterInstanceName = vmSpec.getDetails().get("PeerRouterInstanceName");
    +
    +                    VirtualMachineMO peerVmMo = hyperHost.findVmOnHyperHost(peerRouterInstanceName);
    +                    if (peerVmMo == null) {
    +                        peerVmMo = hyperHost.findVmOnPeerHyperHost(peerRouterInstanceName);
    +                    }
    +
    +                    if (peerVmMo != null) {
    +                        StringBuffer sbOldMacSequence = new StringBuffer();
    +                        for (NicTO oldNicTo : sortNicsByDeviceId(nics)) {
    +                            sbOldMacSequence.append(oldNicTo.getMac()).append("|");
    +                        }
    +                        if (!sbOldMacSequence.toString().isEmpty()) {
    +                            sbOldMacSequence.deleteCharAt(sbOldMacSequence.length() - 1); //Remove extra '|' char appended at the end
    +                        }
    +
    +                        for (int nicIndex = nics.length - extraPublicNics; nicIndex < nics.length; nicIndex++) {
    +                            VirtualDevice nicDevice = peerVmMo.getNicDeviceByIndex(nics[nicIndex].getDeviceId());
    +                            if (nicDevice != null) {
    +                                String mac = ((VirtualEthernetCard)nicDevice).getMacAddress();
    +                                if (mac != null) {
    +                                    s_logger.info("Use same MAC as previous RvR, the MAC is " + mac + " for extra NIC with device id: " + nics[nicIndex].getDeviceId());
    +                                    nics[nicIndex].setMac(mac);
    +                                }
    +                            }
    +                        }
    +
    +                        String bootArgs = vmSpec.getBootArgs();
    +                        if (!StringUtils.isEmpty(bootArgs)) {
    +                            StringBuffer sbNewMacSequence = new StringBuffer();
    --- End diff --
    
    This method is still quite big.
    What about extracting lines 1966-1971 to a method? These lines are used to generate/create the `sbNewMacSequence`. Then we could have a documentation describing its workings and test cases.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @rafaelweingartner  Sure. I'll move these lines to a method and push the changes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by sureshanaparti <gi...@git.apache.org>.
Github user sureshanaparti commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @PaulAngus What was the error shown for duplicate MAC in vCenter. Can you post the log snippet with the error. These changes were tested in vCenter 5.5 and 6.0, didn't observe any issues in vCenter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1878#discussion_r105679910
  
    --- Diff: plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java ---
    @@ -216,6 +216,20 @@ public void testScaleVMF1() throws Exception {
         }
     
         @Test
    +    public void testReplaceNicsMacSequenceInBootArgs() throws Exception {
    --- End diff --
    
    Do you need this `throws Exception` here?
    It does not seem o be required by any of the method calls you have here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatchi...

Posted by rafaelweingartner <gi...@git.apache.org>.
Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1878#discussion_r105677642
  
    --- Diff: plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java ---
    @@ -2072,6 +2121,17 @@ protected StartAnswer execute(StartCommand cmd) {
         }
     
         /**
    +     * Update boot args with the new nic mac addresses.
    +     */
    +    protected String replaceNicsMacSequenceInBootArgs(String oldMacSequence, String newMacSequence, VirtualMachineTO vmSpec) {
    +        String bootArgs = vmSpec.getBootArgs();
    +        if (!StringUtils.isEmpty(bootArgs) && !StringUtils.isEmpty(oldMacSequence) && !StringUtils.isEmpty(newMacSequence)) {
    +            return bootArgs.replace(oldMacSequence, newMacSequence);
    +        }
    +        return "";
    --- End diff --
    
    Is this case possible? `bootArgs` not empty and `oldMacSequence` or `newMacSequence` empty
    
    If so, would not it be better to return at line 2131 the variable `bootArgs`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    <b>Trillian test result (tid-873)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 33766 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1878-t873-kvm-centos7.zip
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
    Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
    Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
    Test completed. 46 look ok, 3 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 362.57 | test_vpc_redundant.py
    test_04_rvpc_privategw_static_routes | `Failure` | 334.37 | test_privategw_acl.py
    test_02_list_snapshots_with_removed_data_store | `Error` | 0.03 | test_snapshots.py
    test_01_vpc_site2site_vpn | Success | 159.36 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 65.83 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 239.78 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 274.04 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 531.49 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 509.60 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1410.18 | test_vpc_redundant.py
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | Success | 536.46 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | Success | 747.15 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 151.49 | test_volumes.py
    test_08_resize_volume | Success | 156.71 | test_volumes.py
    test_07_resize_fail | Success | 156.11 | test_volumes.py
    test_06_download_detached_volume | Success | 155.99 | test_volumes.py
    test_05_detach_volume | Success | 150.63 | test_volumes.py
    test_04_delete_attached_volume | Success | 150.93 | test_volumes.py
    test_03_download_attached_volume | Success | 156.02 | test_volumes.py
    test_02_attach_volume | Success | 95.59 | test_volumes.py
    test_01_create_volume | Success | 711.06 | test_volumes.py
    test_03_delete_vm_snapshots | Success | 275.18 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Success | 95.70 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Success | 158.66 | test_vm_snapshots.py
    test_deploy_vm_multiple | Success | 267.19 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.64 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 125.11 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 40.67 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.06 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.92 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 126.20 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.13 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 40.26 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 60.49 | test_templates.py
    test_08_list_system_templates | Success | 0.02 | test_templates.py
    test_07_list_public_templates | Success | 0.02 | test_templates.py
    test_05_template_permissions | Success | 0.04 | test_templates.py
    test_04_extract_template | Success | 5.14 | test_templates.py
    test_03_delete_template | Success | 5.08 | test_templates.py
    test_02_edit_template | Success | 90.16 | test_templates.py
    test_01_create_template | Success | 30.29 | test_templates.py
    test_10_destroy_cpvm | Success | 131.42 | test_ssvm.py
    test_09_destroy_ssvm | Success | 168.49 | test_ssvm.py
    test_08_reboot_cpvm | Success | 131.51 | test_ssvm.py
    test_07_reboot_ssvm | Success | 133.41 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.56 | test_ssvm.py
    test_05_stop_ssvm | Success | 133.54 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.14 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.29 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.08 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.09 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 10.94 | test_snapshots.py
    test_04_change_offering_small | Success | 239.55 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.07 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.12 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.12 | test_secondary_storage.py
    test_09_reboot_router | Success | 40.27 | test_routers.py
    test_08_start_router | Success | 30.20 | test_routers.py
    test_07_stop_router | Success | 10.13 | test_routers.py
    test_06_router_advanced | Success | 0.04 | test_routers.py
    test_05_router_basic | Success | 0.03 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.64 | test_routers.py
    test_03_restart_network_cleanup | Success | 60.40 | test_routers.py
    test_02_router_internal_adv | Success | 1.04 | test_routers.py
    test_01_router_internal_basic | Success | 0.56 | test_routers.py
    test_router_dns_guestipquery | Success | 76.61 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.06 | test_router_dns.py
    test_router_dhcphosts | Success | 278.02 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.59 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.05 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 145.80 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.03 | test_regions.py
    test_create_pvlan_network | Success | 5.14 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.31 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 483.44 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 348.47 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 81.57 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.69 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.15 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.31 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 89.19 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.10 | test_over_provisioning.py
    test_oobm_zchange_password | Success | 30.47 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.26 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.21 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.27 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 15.28 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 87.44 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 5.12 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 0.10 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.07 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 23.31 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.25 | test_non_contigiousvlan.py
    test_01_nic | Success | 433.23 | test_nic.py
    test_releaseIP | Success | 242.55 | test_network.py
    test_reboot_router | Success | 407.73 | test_network.py
    test_public_ip_user_account | Success | 10.19 | test_network.py
    test_public_ip_admin_account | Success | 40.20 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.73 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.53 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.08 | test_network.py
    test_delete_account | Success | 272.02 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.46 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.67 | test_network.py
    test_nic_secondaryip_add_remove | Success | 201.92 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 17.80 | test_login.py
    test_assign_and_removal_lb | Success | 133.46 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 187.19 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 217.54 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.04 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.04 | test_iso.py
    test_05_iso_permissions | Success | 0.04 | test_iso.py
    test_04_extract_Iso | Success | 5.42 | test_iso.py
    test_03_delete_iso | Success | 95.13 | test_iso.py
    test_02_edit_iso | Success | 0.04 | test_iso.py
    test_01_create_iso | Success | 20.67 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 192.90 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 142.25 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 511.18 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 438.99 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.19 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.24 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 5.79 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 5.66 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.58 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.66 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 5.67 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 5.59 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.66 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.61 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 10.62 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.60 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.58 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 6.96 | test_dynamicroles.py
    test_role_account_acls | Success | 7.14 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.66 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.07 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 20.40 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 20.49 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 60.48 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 25.34 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 50.49 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 5.79 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.65 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 206.83 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 206.88 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 60.67 | test_affinity_groups.py
    test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
    test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py
    test_3d_gpu_support | Skipped | 0.03 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1878: CLOUDSTACK-9717: [VMware] RVRs have mismatching MAC ...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1878
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---