[GitHub] [spark] viirya commented on a change in pull request #24896: [WIP][SPARK-28006] User-defined grouped transform pandas_udf for window operations

[GitBox <gi...@apache.org>]

viirya commented on a change in pull request #24896: [WIP][SPARK-28006] User-defined grouped transform pandas_udf for window operations
URL: https://github.com/apache/spark/pull/24896#discussion_r294573956
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/PythonUDF.scala
 ##########
 @@ -40,9 +40,15 @@ object PythonUDF {
       e.asInstanceOf[PythonUDF].evalType == PythonEvalType.SQL_GROUPED_AGG_PANDAS_UDF
   }
 
+  def isGroupedXformPandasUDF(e: Expression): Boolean = {
+    e.isInstanceOf[PythonUDF] &&
+      e.asInstanceOf[PythonUDF].evalType == PythonEvalType.SQL_GROUPED_XFORM_PANDAS_UDF
+  }
+
   // This is currently same as GroupedAggPandasUDF, but we might support new types in the future,
 
 Review comment:
   Change the comment together?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org