You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/11/27 05:37:29 UTC

[GitHub] [dubbo-samples] kacperfronc opened a new issue #185: Update dubbo-samples-api to not use deprecated code

kacperfronc opened a new issue #185:
URL: https://github.com/apache/dubbo-samples/issues/185


   Currently those files are using deprecated call:
   `AbstractInterfaceConfig::setApplication`. 
   Since those are examples that are used in `README.md` in dubbo project, it would be nice if they didn't show deprecated code, because it's also not trivial to understand why it's deprecated.
   The code itself just uses `@Deprecated` without any comment whatsoever and there are no examples in `README.md` that show how that should look. The way I found it was by seeing this issue: https://github.com/apache/dubbo/issues/5679
   
   After this gets updated here, I assume, the same has to be done in https://github.com/apache/dubbo in README.md, maybe in some other places too.
   
   Now, this deprecated code is used all over dubbo-samples, but this submodule seems to be more important, as the code to it is shown as the first thing for people that try to learn and use the framework.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org