You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@xtable.apache.org by "the-other-tim-brown (via GitHub)" <gi...@apache.org> on 2025/03/09 15:26:58 UTC

[PR] minor fixes recommended from static analysis tooling [incubator-xtable]

the-other-tim-brown opened a new pull request, #664:
URL: https://github.com/apache/incubator-xtable/pull/664

   ## *Important Read*
   - *Please ensure the GitHub issue is mentioned at the beginning of the PR*
   
   ## What is the purpose of the pull request
   
   *(For example: This pull request implements the sync for delta format.)*
   
   ## Brief change log
   
   *(for example:)*
   - *Fixed JSON parsing error when persisting state*
   - *Added unit tests for schema evolution*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
   - *Added integration tests for end-to-end.*
   - *Added TestConversionController to verify the change.*
   - *Manually verified the change by running a job locally.*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] fixes recommended from static analysis tooling [incubator-xtable]

Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown commented on PR #664:
URL: https://github.com/apache/incubator-xtable/pull/664#issuecomment-2711877717

   > LGTM 👍 Could you share which tool generated these recommendations? And if we recommend all contributors to use if available?
   
   @ashvina it is Sonar and I have it setup to run on our internal fork but I think there is a fee you must pay per developer. I am not sure if there are any similar tools available to Apache projects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [MINOR] fixes recommended from static analysis tooling [incubator-xtable]

Posted by "the-other-tim-brown (via GitHub)" <gi...@apache.org>.
the-other-tim-brown merged PR #664:
URL: https://github.com/apache/incubator-xtable/pull/664


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@xtable.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org