You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/08 14:52:35 UTC

[GitHub] [camel-kafka-connector] orpiske edited a comment on issue #102: Auto gen step 2: generated connectors structure and dependencies.

orpiske edited a comment on issue #102: Auto gen step 2: generated connectors structure and dependencies.
URL: https://github.com/apache/camel-kafka-connector/pull/102#issuecomment-596213804
 
 
   > I don't fully get what you mean @orpiske :/
   
   No worries. My comment was not very clear. I was thinking about some connector specific configuration that we had. 
   
   For example, I was thinking of this setting we used to set the [JMS destination address](https://github.com/apache/camel-kafka-connector/blob/master/connectors/camel-sjms2-kafka-connector/src/main/java/org/apache/camel/kafkaconnector/sjms2/CamelSjms2SinkConnectorConfig.java#L152).   
   
   I was just wondering/suggesting if it would OK to have those on the [CamelSinkConnectorConfig.java](https://github.com/apache/camel-kafka-connector/blob/master/core/src/main/java/org/apache/camel/kafkaconnector/CamelSinkConnectorConfig.java).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services