You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by anthonycorbacho <gi...@git.apache.org> on 2016/07/13 03:38:28 UTC
[GitHub] zeppelin pull request #1173: ZeppelinHub Realm
GitHub user anthonycorbacho opened a pull request:
https://github.com/apache/zeppelin/pull/1173
ZeppelinHub Realm
### What is this PR for?
Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials.
### What type of PR is it?
`Feature`
### Todos
* [ ] - Create ZeppelinHub Realm that extends `AuthorizingRealm`.
* [ ] - Update `shiro.ini` file and add ZeppelinHub configuration template.
### What is the Jira issue?
No related Jira issue yet.
### How should this be tested?
- Assuming that you already have an account [Zeppelinhub](https://www.zeppelinhub.com/register), edit `conf/shiro.ini` file and uncomment ZeppelinHub related configuration.
- Start your Zeppelin
- Login with your ZeppelinHub credentials.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Maybe [HERE](http://zeppelin.apache.org/docs/0.6.0/security/shiroauthentication.html)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonycorbacho/incubator-zeppelin feat/ZeppelinHubAuthentication
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1173
----
commit 7975467c54d09b5f17e51aa08fc66d5600a2318e
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T03:23:15Z
Create new Apache Shiro Realm for ZeppelinHub
This Realm will let users login with they ZeppelinHub credentials.
commit 24d4ea0ab898b1dfa533a90eff863c5c2b58cbcc
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T03:24:29Z
Add new setting in Shiri.ini to handle ZeppelinHub realm.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1173
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1173
merging if no more discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1173
@khalidhuseynov i think it make sense to do it in this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by anthonycorbacho <gi...@git.apache.org>.
GitHub user anthonycorbacho reopened a pull request:
https://github.com/apache/zeppelin/pull/1173
[ZEPPELIN-1164] ZeppelinHub Realm
### What is this PR for?
Add a new Shiro Realm that lets users authenticate in Apache Zeppelin using their ZeppelinHub credentials.
### What type of PR is it?
`Feature`
### Todos
* [x] - Create ZeppelinHub Realm that extends `AuthorizingRealm`.
* [x] - Update `shiro.ini` file and add ZeppelinHub configuration template.
### What is the Jira issue?
[Issue 1164](https://issues.apache.org/jira/browse/ZEPPELIN-1164)
### How should this be tested?
- Assuming that you already have an account [Zeppelinhub](https://www.zeppelinhub.com/register), edit `conf/shiro.ini` file and uncomment ZeppelinHub related configuration.
- Start your Zeppelin
- Login with your ZeppelinHub credentials.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Maybe [HERE](http://zeppelin.apache.org/docs/0.6.0/security/shiroauthentication.html)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anthonycorbacho/incubator-zeppelin feat/ZeppelinHubAuthentication
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1173
----
commit 7975467c54d09b5f17e51aa08fc66d5600a2318e
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T03:23:15Z
Create new Apache Shiro Realm for ZeppelinHub
This Realm will let users login with they ZeppelinHub credentials.
commit 24d4ea0ab898b1dfa533a90eff863c5c2b58cbcc
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T03:24:29Z
Add new setting in Shiri.ini to handle ZeppelinHub realm.
commit 60b836091b8eb1d6cbed64e530bb3bbffdf96df6
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T03:39:33Z
Change check of token.getUsername() in doGetAuthenticationInfo by using StringUtils::isBlank instead of checking only null.
commit 8da302fe40517cc5c3ac4c7c074ea15bc1c06ade
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T03:52:43Z
Add more method comments.
commit bbd074a9c050f44c913dcca012663b928f864bfd
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T03:55:22Z
Remove author tag...
commit eb5c3d3ea917f962b0cce9ac22c4c29d73946abb
Author: Anthony Corbacho <co...@gmail.com>
Date: 2016-07-13T05:31:31Z
Handle long line > 100 char
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1173
build failed on `zeppelin-web`, which is not relevant. can we still re-trigger CI here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1173
all green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho closed the pull request at:
https://github.com/apache/zeppelin/pull/1173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1173
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1173
@anthonycorbacho I've tried to merge this PR into master and branch-0.6. I've succeeded to merge it into master but failed doing into branch-0.6. Is it OK?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1173
@khalidhuseynov @AhyoungRyu 5a27871f5a9e436653c8862e6d2ecc8913fdd496 for documentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by khalidhuseynov <gi...@git.apache.org>.
Github user khalidhuseynov commented on the issue:
https://github.com/apache/zeppelin/pull/1173
It looks good. one thing is that it should be documented as well so that others may implement their own authentication/authorization realms with their server. do you want to add it as a part of this PR or do it later?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1173
LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm
Posted by anthonycorbacho <gi...@git.apache.org>.
Github user anthonycorbacho commented on the issue:
https://github.com/apache/zeppelin/pull/1173
@jongyoul sure, no problemo
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---