You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/11/14 10:06:46 UTC

svn commit: r1815195 - in /ofbiz: ofbiz-framework/trunk/applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/LoginEvents.java ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java

Author: jleroux
Date: Tue Nov 14 10:06:46 2017
New Revision: 1815195

URL: http://svn.apache.org/viewvc?rev=1815195&view=rev
Log:
Improved: Fixing defects reported by FindBugs, package 
org.apache.ofbiz.securityext.login.
(OFBIZ-9637)

No functional change, missed a compilation issue, 

Thanks: Builbot :)

Modified:
    ofbiz/ofbiz-framework/trunk/applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/LoginEvents.java
    ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java

Modified: ofbiz/ofbiz-framework/trunk/applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/LoginEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/LoginEvents.java?rev=1815195&r1=1815194&r2=1815195&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/LoginEvents.java (original)
+++ ofbiz/ofbiz-framework/trunk/applications/securityext/src/main/java/org/apache/ofbiz/securityext/login/LoginEvents.java Tue Nov 14 10:06:46 2017
@@ -401,7 +401,7 @@ public class LoginEvents {
         return ProductEvents.checkStoreCustomerRole(request, response);
     }
 
-    public static String storeLogin(HttpServletRequest request, HttpServletResponse response) {
+    public static String storeLogin(HttpServletRequest request, HttpServletResponse response) throws UnsupportedEncodingException {
         String responseString = LoginWorker.login(request, response);
         if (!"success".equals(responseString)) {
             return responseString;

Modified: ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java?rev=1815195&r1=1815194&r2=1815195&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java (original)
+++ ofbiz/ofbiz-plugins/trunk/webpos/src/main/java/org/apache/ofbiz/webpos/WebPosEvents.java Tue Nov 14 10:06:46 2017
@@ -18,6 +18,7 @@
  *******************************************************************************/
 package org.apache.ofbiz.webpos;
 
+import java.io.UnsupportedEncodingException;
 import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
@@ -51,7 +52,7 @@ public class WebPosEvents {
 
     public static String module = WebPosEvents.class.getName();
 
-    public static String posLogin(HttpServletRequest request, HttpServletResponse response) {
+    public static String posLogin(HttpServletRequest request, HttpServletResponse response) throws UnsupportedEncodingException {
         HttpSession session = request.getSession(true);
         
         // get the posTerminalId