You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "Yang Ye (JIRA)" <ji...@apache.org> on 2012/05/26 00:59:23 UTC
[jira] [Created] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Yang Ye created KAFKA-349:
-----------------------------
Summary: Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
Key: KAFKA-349
URL: https://issues.apache.org/jira/browse/KAFKA-349
Project: Kafka
Issue Type: Improvement
Reporter: Yang Ye
Assignee: Yang Ye
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.9
81. LeaderAndISRRequest and StopReplicaRequest: Could we add a default value for versionId and clientId in the constructor (like in FetchRequest)?
Did that
82. ProducerResponse and OffsetResponse: remove val CurrentVersion.
Did that
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7, kafka_responseSend.patch.8, kafka_responseSend.patch.9
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (KAFKA-349) Create individual "Response"
types for each kind of request and wrap them with "BoundedByteBufferSend",
remove "xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283803#comment-13283803 ]
Yang Ye edited comment on KAFKA-349 at 5/25/12 11:07 PM:
---------------------------------------------------------
1. Replace "Requst" type with "RequestOrResponse" and move it to "kafka.api" from "kafka.network"
2. Create "FetchResponse", "ProducerResponse", "TopicMetaDataResponse", "OffsetResponse" class
3. Move the error code inside the response classes
4. Change the code in "KafkaApis" in response to the change in response formats
5. Change the Blocking channel receive function to receive just the response (with error code inside) instead of tuple of response and error code.
6. Remove unnecessary "serialization" and "deserialization" functions
7. Change corresponding test classes
was (Author: yeyangever):
1. Replace "Requst" type with "RequestOrResponse" and move it to "kafka.api" from "kafka.network"
2. Create "FetchResponse", "ProducerResponse", "TopicMetaDataResponse", "OffsetResponse" class
3. Move the error code inside the response classes
4. Change the code in "KafkaApis" in response to the change in response formats
5. Change the Blocking channel receive function to receive just the response (with error code inside) instead of tuple of response and error code.
6. Remove unnecessary "serialization" and "deserialization" functions
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13289865#comment-13289865 ]
Jun Rao commented on KAFKA-349:
-------------------------------
A few more comments for patch v8.
81. LeaderAndISRRequest and StopReplicaRequest: Could we add a default value for versionId and clientId in the constructor (like in FetchRequest)?
82. ProducerResponse and OffsetResponse: remove val CurrentVersion.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7, kafka_responseSend.patch.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288807#comment-13288807 ]
Jun Rao commented on KAFKA-349:
-------------------------------
75. ControllerToBrokerRequestTest should use TestUtils.createBrokerConfigs to create broker properties.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287830#comment-13287830 ]
Jun Rao commented on KAFKA-349:
-------------------------------
Thanks for patch v7. Some comments:
71. LeaderAndISRRequest:
71.1 constructor: can we put versionId and clientId before the rest of the fields?
71.2 writeTo(): we should put versionId first and clientId second.
72. KafkaApis: in handleLeaderAndISR() and handleStopReplica(), add a TODO comment that the actually logic will be put in later.
73: ProducerReponse.writeTo: Let's put correlationId before errorcode, to be consistent.
74. ControllerToBrokerRequestTest seems to fail for me. You need to remove unit. from the package name.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286737#comment-13286737 ]
Jun Rao commented on KAFKA-349:
-------------------------------
Thanks for patch v6. Some new comments:
61. FetchResponse, ProducerResponse: VersionId should be the first item is serialized data since we will be depending on VersionId to deserialize the right version of the data in the future.
62. Could you rebase since trunk has moved?
63. The only test that fails for me is testCleanupExpiredSegments, which is fixed as part of merging from trunk to 0.8. If you rebase, that test should pass.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jun Rao resolved KAFKA-349.
---------------------------
Resolution: Fixed
Fix Version/s: 0.8
Thanks for patch v9. Just committed to 0.8.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Fix For: 0.8
>
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7, kafka_responseSend.patch.8, kafka_responseSend.patch.9
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.8
71. LeaderAndISRRequest:
71.1 constructor: can we put versionId and clientId before the rest of the fields?
did that
71.2 writeTo(): we should put versionId first and clientId second.
did that
72. KafkaApis: in handleLeaderAndISR() and handleStopReplica(), add a TODO comment that the actually logic will be put in later.
did that
73: ProducerReponse.writeTo: Let's put correlationId before errorcode, to be consistent.
did that
74. ControllerToBrokerRequestTest seems to fail for me. You need to remove unit. from the package name.
did that
75. ControllerToBrokerRequestTest should use TestUtils.createBrokerConfigs to create broker properties.
did that
All tests passed on my local machine
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7, kafka_responseSend.patch.8
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284887#comment-13284887 ]
Jun Rao commented on KAFKA-349:
-------------------------------
Also, unit tests seem to fail due to the wire protocol changes.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.6
1. Added the versionId in ProducerResponse and FetchResponse
2. Fix one error that leads to test failures. All unit tests been tested through, all passed except two ("testCleanupExpiredSegments" in "LogManagerTest") and "BackwardsCompatibilityTest", but they also fail at the Kafka 0.8 repo. (So it's irrelevant to this patch)
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.5
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.4
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283803#comment-13283803 ]
Yang Ye commented on KAFKA-349:
-------------------------------
1. Replace "Requst" type with "RequestOrResponse" and move it to "kafka.api" from "kafka.network"
2. Create "FetchResponse", "ProducerResponse", "TopicMetaDataResponse", "OffsetResponse" class
3. Move the error code inside the response classes
4. Change the code in "KafkaApis" in response to the change in response formats
5. Change the Blocking channel receive function to receive just the response (with error code inside) instead of tuple of response and error code.
6. Remove unnecessary "serialization" and "deserialization" functions
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13284590#comment-13284590 ]
Jun Rao commented on KAFKA-349:
-------------------------------
Thanks for patch v5. One more comment:
51. FetchResponse,ProducerResponse: We will still need to send the versionId to the client so that the client knows if it gets the right version of the response. We just don't need CurrentVersion in FetchResponse/ProducerResponse since we should just refer to the version constant in FetchRequest/ProducerRequest.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283895#comment-13283895 ]
Yang Ye commented on KAFKA-349:
-------------------------------
1. Change all the error code in the system to Short type
2. Remove the "version id" type from all the response classes
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KAFKA-349) Create individual "Response" types
for each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13283877#comment-13283877 ]
Jun Rao commented on KAFKA-349:
-------------------------------
That's a good cleanup patch. Thanks. Some comments:
1. Maybe we should use this opportunity to make the error code length in all responses consistent (use short int instead of int).
2. The response classes don't need to store CurrentVersion since their version is always the same as the corresponding request.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.3
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.7
I'm sorry but it's really hard to decouple the RPC patch from the "cleanup" patch, since the latter depends on the first. Jun, can you help check them in all together? This submitted patch include three parts:
1. Rebase from Neha's latest commit
2. the cleanup patch
3. the RPC patch.
All tests passed.
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2, kafka_responseSend.patch.3, kafka_responseSend.patch.4, kafka_responseSend.patch.5, kafka_responseSend.patch.6, kafka_responseSend.patch.7
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KAFKA-349) Create individual "Response" types for
each kind of request and wrap them with "BoundedByteBufferSend", remove
"xxResponseSend" types for all requests except "FetchRequest"
Posted by "Yang Ye (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KAFKA-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yang Ye updated KAFKA-349:
--------------------------
Attachment: kafka_responseSend.patch.2
> Create individual "Response" types for each kind of request and wrap them with "BoundedByteBufferSend", remove "xxResponseSend" types for all requests except "FetchRequest"
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-349
> URL: https://issues.apache.org/jira/browse/KAFKA-349
> Project: Kafka
> Issue Type: Improvement
> Reporter: Yang Ye
> Assignee: Yang Ye
> Attachments: kafka_responseSend.patch, kafka_responseSend.patch.2
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira