You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/05/09 08:35:36 UTC
[GitHub] [incubator-doris] WingsGo opened a new pull request #3539: Throw DdlException when use admin set frontend config
WingsGo opened a new pull request #3539:
URL: https://github.com/apache/incubator-doris/pull/3539
When execute Ddl `admin set frontend config`. User will get msg `ERROR 1064 (HY000): Unexpected exception: null`, it is confusing, we should give user a more friendly tip info.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3539: Throw DdlException when use admin set frontend config
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3539:
URL: https://github.com/apache/incubator-doris/pull/3539#issuecomment-626129536
For #3538
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on a change in pull request #3539: Throw DdlException when use admin set frontend config
Posted by GitBox <gi...@apache.org>.
WingsGo commented on a change in pull request #3539:
URL: https://github.com/apache/incubator-doris/pull/3539#discussion_r422573622
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -6385,7 +6385,10 @@ public void replayDropFunction(FunctionSearchDesc functionSearchDesc) {
public void setConfig(AdminSetConfigStmt stmt) throws DdlException {
Map<String, String> configs = stmt.getConfigs();
- Preconditions.checkState(configs.size() == 1);
+ // configs can not be null
+ if (configs.size() != 1) {
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #3539: Throw DdlException when use admin set frontend config
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #3539:
URL: https://github.com/apache/incubator-doris/pull/3539#discussion_r422486197
##########
File path: fe/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -6385,7 +6385,10 @@ public void replayDropFunction(FunctionSearchDesc functionSearchDesc) {
public void setConfig(AdminSetConfigStmt stmt) throws DdlException {
Map<String, String> configs = stmt.getConfigs();
- Preconditions.checkState(configs.size() == 1);
+ // configs can not be null
+ if (configs.size() != 1) {
Review comment:
This should be done in `AdminSetConfigStmt`'s `analyze` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WingsGo commented on pull request #3539: Throw DdlException when use admin set frontend config
Posted by GitBox <gi...@apache.org>.
WingsGo commented on pull request #3539:
URL: https://github.com/apache/incubator-doris/pull/3539#issuecomment-626486846
> `fe/src/test/java/org/apache/doris/analysis/AminSetConfigStmtTest` no file extension;
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org