You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by ta...@apache.org on 2012/08/27 20:26:22 UTC

svn commit: r1377779 - /activemq/trunk/activemq-core/src/test/java/org/apache/activemq/store/kahadb/plist/PListTest.java

Author: tabish
Date: Mon Aug 27 18:26:22 2012
New Revision: 1377779

URL: http://svn.apache.org/viewvc?rev=1377779&view=rev
Log:
fix for: https://issues.apache.org/jira/browse/AMQ-3995

Remove the long and not so useful serial add test.

Modified:
    activemq/trunk/activemq-core/src/test/java/org/apache/activemq/store/kahadb/plist/PListTest.java

Modified: activemq/trunk/activemq-core/src/test/java/org/apache/activemq/store/kahadb/plist/PListTest.java
URL: http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/test/java/org/apache/activemq/store/kahadb/plist/PListTest.java?rev=1377779&r1=1377778&r2=1377779&view=diff
==============================================================================
--- activemq/trunk/activemq-core/src/test/java/org/apache/activemq/store/kahadb/plist/PListTest.java (original)
+++ activemq/trunk/activemq-core/src/test/java/org/apache/activemq/store/kahadb/plist/PListTest.java Mon Aug 27 18:26:22 2012
@@ -48,7 +48,6 @@ public class PListTest {
     final Vector<Throwable> exceptions = new Vector<Throwable>();
     ExecutorService executor;
 
-
     @Test
     public void testAddLast() throws Exception {
         final int COUNT = 1000;
@@ -147,7 +146,6 @@ public class PListTest {
         assertFalse(plist.remove("doesNotExist"));
     }
 
-
     @Test
     public void testRemoveSingleEntry() throws Exception {
         plist.addLast("First", new ByteSequence("A".getBytes()));
@@ -169,7 +167,6 @@ public class PListTest {
         assertFalse(plist.remove(0));
     }
 
-
     @Test
     public void testConcurrentAddRemove() throws Exception {
         File directory = store.getDirectory();
@@ -260,7 +257,6 @@ public class PListTest {
         assertTrue("finished ok", finishedInTime);
     }
 
-
     @Test
     public void testConcurrentAddLast() throws Exception {
         File directory = store.getDirectory();
@@ -310,7 +306,6 @@ public class PListTest {
         LOG.info("After remove index file: " + store.pageFile.getFile().length());
     }
 
-
     @Test
     public void testConcurrentAddRemoveWithPreload() throws Exception {
         File directory = store.getDirectory();
@@ -443,40 +438,6 @@ public class PListTest {
     }
 
     @Test
-    public void testSerialAddIterate() throws Exception {
-        File directory = store.getDirectory();
-        store.stop();
-        IOHelper.mkdirs(directory);
-        IOHelper.deleteChildren(directory);
-        store = new PListStore();
-        store.setIndexPageSize(512);
-        store.setJournalMaxFileLength(100*1024);
-        store.setDirectory(directory);
-        store.setCleanupInterval(-1);
-        store.setIndexEnablePageCaching(false);
-        store.setIndexWriteBatchSize(2000);
-        store.setEnableIndexWriteAsync(false);
-        store.start();
-
-        final int iterations = 1000;
-        final int numLists = 1;
-
-        LOG.info("create");
-        for (int i=0; i<numLists;i++) {
-            new Job(i, PListTest.TaskType.CREATE, iterations).run();
-        }
-
-        LOG.info("serial add and iterate");
-        for (int i=0; i<iterations; i++) {
-            new Job(0, TaskType.ADD, i).run();
-            new Job(0, TaskType.ITERATE, 0).run();
-        }
-
-        assertTrue("no exceptions: " + exceptions, exceptions.isEmpty());
-        LOG.info("Num dataFiles:" + store.getJournal().getFiles().size());
-    }
-
-    @Test
     public void testConcurrentAddIterate() throws Exception {
         File directory = store.getDirectory();
         store.stop();