You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by rr...@apache.org on 2018/07/08 03:13:31 UTC

[trafficserver] branch master updated (f4f2b04 -> 43d495e)

This is an automated email from the ASF dual-hosted git repository.

rrm pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git.


    from f4f2b04  add function for TSHttpTxnAborted
     new fdab3cd  Removes no-op macros ACQUIRE_PRINT_LOCK and RELEASE_PRINT_LOCK
     new 43d495e  Removes duplicated validity check

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 proxy/http/HttpTransact.h       | 5 -----
 proxy/http/HttpTransactCache.cc | 7 -------
 2 files changed, 12 deletions(-)


[trafficserver] 01/02: Removes no-op macros ACQUIRE_PRINT_LOCK and RELEASE_PRINT_LOCK

Posted by rr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

rrm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit fdab3cdd764ed53e3b6506e88a1642b3aee36734
Author: Randall Meyer <ra...@yahoo.com>
AuthorDate: Tue Jul 3 13:12:52 2018 -0700

    Removes no-op macros ACQUIRE_PRINT_LOCK and RELEASE_PRINT_LOCK
---
 proxy/http/HttpTransact.h       | 5 -----
 proxy/http/HttpTransactCache.cc | 4 ----
 2 files changed, 9 deletions(-)

diff --git a/proxy/http/HttpTransact.h b/proxy/http/HttpTransact.h
index 3ad3211..962c864 100644
--- a/proxy/http/HttpTransact.h
+++ b/proxy/http/HttpTransact.h
@@ -45,13 +45,9 @@
 
 #define HTTP_RELEASE_ASSERT(X) ink_release_assert(X)
 
-#define ACQUIRE_PRINT_LOCK() // ink_mutex_acquire(&print_lock);
-#define RELEASE_PRINT_LOCK() // ink_mutex_release(&print_lock);
-
 #define DUMP_HEADER(T, H, I, S)                                 \
   {                                                             \
     if (diags->on(T)) {                                         \
-      ACQUIRE_PRINT_LOCK()                                      \
       fprintf(stderr, "+++++++++ %s +++++++++\n", S);           \
       fprintf(stderr, "-- State Machine Id: %" PRId64 "\n", I); \
       char b[4096];                                             \
@@ -68,7 +64,6 @@
           fprintf(stderr, "%s", b);                             \
         } while (!done);                                        \
       }                                                         \
-      RELEASE_PRINT_LOCK()                                      \
     }                                                           \
   }
 
diff --git a/proxy/http/HttpTransactCache.cc b/proxy/http/HttpTransactCache.cc
index fa735a3..7a6be4e 100644
--- a/proxy/http/HttpTransactCache.cc
+++ b/proxy/http/HttpTransactCache.cc
@@ -180,9 +180,7 @@ HttpTransactCache::SelectFromAlternates(CacheHTTPInfoVector *cache_vector, HTTPH
   Debug("http_match", "[SelectFromAlternates] # alternates = %d", alt_count);
   Debug("http_seq", "[SelectFromAlternates] %d alternates for this cached doc", alt_count);
   if (is_debug_tag_set("http_alts")) {
-    ACQUIRE_PRINT_LOCK()
     fprintf(stderr, "[alts] There are %d alternates for this request header.\n", alt_count);
-    RELEASE_PRINT_LOCK()
   }
 
   if (!client_request->valid()) {
@@ -256,9 +254,7 @@ HttpTransactCache::SelectFromAlternates(CacheHTTPInfoVector *cache_vector, HTTPH
   }
   Debug("http_seq", "[SelectFromAlternates] Chosen alternate # %d", best_index);
   if (is_debug_tag_set("http_alts")) {
-    ACQUIRE_PRINT_LOCK()
     fprintf(stderr, "[alts] and the winner is alternate number %d\n", best_index);
-    RELEASE_PRINT_LOCK()
   }
 
   if ((best_index != -1) && (best_Q > unacceptable_Q)) {


[trafficserver] 02/02: Removes duplicated validity check

Posted by rr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

rrm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git

commit 43d495e8439df9759cade694608a1ccf00a29e83
Author: Randall Meyer <ra...@yahoo.com>
AuthorDate: Tue Jul 3 13:16:04 2018 -0700

    Removes duplicated validity check
---
 proxy/http/HttpTransactCache.cc | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/proxy/http/HttpTransactCache.cc b/proxy/http/HttpTransactCache.cc
index 7a6be4e..5febd74 100644
--- a/proxy/http/HttpTransactCache.cc
+++ b/proxy/http/HttpTransactCache.cc
@@ -183,9 +183,6 @@ HttpTransactCache::SelectFromAlternates(CacheHTTPInfoVector *cache_vector, HTTPH
     fprintf(stderr, "[alts] There are %d alternates for this request header.\n", alt_count);
   }
 
-  if (!client_request->valid()) {
-    return 0;
-  }
   // so that plugins can make cache reads for http
   // docs to check if the doc exists in the cache
   if (!client_request->valid()) {