[jira] [Commented] (THRIFT-4026) TSSLSocket doesn't work with Python < 2.7.9

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15844006#comment-15844006 ] 

ASF GitHub Bot commented on THRIFT-4026:
----------------------------------------

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/1166

    THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-4026

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1166.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1166
    
----
commit a348099d80a331a81e7f224cf8299933517e9895
Author: Nobuaki Sukegawa <ns...@gmail.com>
Date:   2017-01-28T09:53:01Z

    THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9

----


> TSSLSocket doesn't work with Python < 2.7.9
> -------------------------------------------
>
>                 Key: THRIFT-4026
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4026
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Library
>    Affects Versions: 0.10.0
>         Environment: Python 2.7.5
>            Reporter: Benoit Sigoure
>            Assignee: Aki Sukegawa
>            Priority: Critical
>
> As a result of a change made in THRIFT-3917, {{TSSLSocket}} now fails with a {{TypeError}} in {{open()}}:
> {code}
>   File "/bld/thrift/Artools-rpmbuild/thrift-0.10.0/lib/py/build/lib.linux-i686-2.7/thrift/transport/TSSLSocket.py", line 293, in open
>     self._validate_callback(self.peercert, self._server_hostname)
> TypeError: legacy_validate_callback() takes exactly 3 arguments (2 given)
> {code}
> Indeed, {{legacy_validate_callback()}} takes an extra {{self}} argument, which cannot possibly be compatible with the signature of [{{ssl.match_hostname()}}|https://docs.python.org/3/library/ssl.html#ssl.match_hostname] (which was added in Python 3.2).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)