[GitHub] [spark] Hisoka-X commented on a diff in pull request #40963: [SPARK-43288][SQL] DataSourceV2: CREATE TABLE LIKE

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #40963:
URL: https://github.com/apache/spark/pull/40963#discussion_r1186573656


##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLParserSuite.scala:
##########
@@ -754,7 +754,7 @@ class DDLParserSuite extends AnalysisTest with SharedSparkSession {
         stop = 125))
   }
 
-  test("create table like") {
+  ignore("create table like") {

Review Comment:
   Add comment for why `ignore`.



##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/v2Commands.scala:
##########
@@ -537,6 +537,26 @@ case class ReplaceTableAsSelect(
   }
 }
 
+/**
+ * Create a table based on another table.
+ *
+ * Note: this does not use V2CreateTablePlan because it doesn't set partitioning.
+ */
+case class CreateTableLike(
+    targetTable: LogicalPlan,
+    sourceTable: LogicalPlan,
+    provider: Option[String],

Review Comment:
   You can use `TableSpec` instand of `provider` and `location` so on.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org