You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/08/05 19:02:40 UTC
[GitHub] [accumulo] dlmarion opened a new issue, #2852: ZooZap catches overly broad exceptions
dlmarion opened a new issue, #2852:
URL: https://github.com/apache/accumulo/issues/2852
Modify ZooZap to catch more narrow exceptions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2852:
URL: https://github.com/apache/accumulo/issues/2852#issuecomment-1208330708
This is the direct link to the comment, in context: https://github.com/apache/accumulo/pull/2665#discussion_r938955552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2852:
URL: https://github.com/apache/accumulo/issues/2852#issuecomment-1208318075
The comment that spawned this issue was very specific to the code where it was newly being introduced. We already have occurrences where we catch overly broad exceptions when we shouldn't, or rewrap RTEs with another RTE as a result, as well as occurrences where we throw overly generic exception types. The point of the original comment was to avoid introducing new such occurrences, not to address all the existing ones. You'd have to go back to the original comment/issue to address the specific ones being added here that should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on issue #2852:
URL: https://github.com/apache/accumulo/issues/2852#issuecomment-1208345779
> GitHub gave me the link to the comment, but apparently doesn't display it.
It sometimes takes a bit to load and expand the collapsed comments. It should work if you open it in a new tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion closed issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
dlmarion closed issue #2852: ZooZap catches overly broad exceptions
URL: https://github.com/apache/accumulo/issues/2852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #2852:
URL: https://github.com/apache/accumulo/issues/2852#issuecomment-1208333803
GitHub gave me the link to the comment, but apparently doesn't display it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #2852:
URL: https://github.com/apache/accumulo/issues/2852#issuecomment-1208008359
> Was there some specific behavior that you wanted to be done differently for error handling depending on the different thrown exceptions in this case?
No, I don't believe so. The comment that spawned this issue was just we should just catch the exceptions that are thrown and not all RuntimeExceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
cshannon commented on issue #2852:
URL: https://github.com/apache/accumulo/issues/2852#issuecomment-1207244098
From taking a quick peak at this it looks like the checked exceptions that need to be caught are just KeeperException and InterruptedException and it seems like most places in the code (if not all) batch both at the same time and handle the same. Was there some specific behavior that you wanted to be done differently for error handling depending on the different thrown exceptions in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on issue #2852: ZooZap catches overly broad exceptions
Posted by GitBox <gi...@apache.org>.
dlmarion commented on issue #2852:
URL: https://github.com/apache/accumulo/issues/2852#issuecomment-1208327055
See https://github.com/apache/accumulo/pull/2665/files#r938955552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org