You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by tw...@apache.org on 2019/07/22 12:47:43 UTC
[flink] branch master updated (7ba2298 -> 71283e2)
This is an automated email from the ASF dual-hosted git repository.
twalthr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from 7ba2298 [FLINK-13266] [table] remove definedTimeAttributes file in blink planner
new 768731d [FLINK-13266][table-runtime-blink] remove Order class from table-runtime-blink
new 71283e2 [FLINK-13266][table-common] Improve comment for FilterableTableTableSource
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../flink/table/sources/FilterableTableSource.java | 5 +++
.../org/apache/flink/table/api/dataview/Order.java | 38 ----------------------
2 files changed, 5 insertions(+), 38 deletions(-)
delete mode 100644 flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/api/dataview/Order.java
[flink] 01/02: [FLINK-13266][table-runtime-blink] remove Order
class from table-runtime-blink
Posted by tw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
twalthr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 768731d2707bf40fefba5481ed20f9c3c3ea1673
Author: godfreyhe <go...@163.com>
AuthorDate: Thu Jul 18 15:11:28 2019 +0800
[FLINK-13266][table-runtime-blink] remove Order class from table-runtime-blink
---
.../org/apache/flink/table/api/dataview/Order.java | 38 ----------------------
1 file changed, 38 deletions(-)
diff --git a/flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/api/dataview/Order.java b/flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/api/dataview/Order.java
deleted file mode 100644
index ad46e38..0000000
--- a/flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/api/dataview/Order.java
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.flink.table.api.dataview;
-
-/**
- * Enumeration representing order.
- */
-public enum Order {
- ASCENDING("ASC"),
-
- DESCENDING("DESC");
-
- public final String shortString;
-
- Order(String shortString) {
- this.shortString = shortString;
- }
-
- public String toString() {
- return shortString;
- }
-}
[flink] 02/02: [FLINK-13266][table-common] Improve comment for
FilterableTableTableSource
Posted by tw...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
twalthr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 71283e27e2b4ca5274f791d46e085b940b8cf215
Author: godfreyhe <go...@163.com>
AuthorDate: Fri Jul 19 16:01:57 2019 +0800
[FLINK-13266][table-common] Improve comment for FilterableTableTableSource
Flink planner planner will push down PlannerExpressions (which are defined in flink-table-planner module), while Blink planner will push down Expressions. So the implementation for Flink planner and Blink planner should be different and incompatible.
---
.../java/org/apache/flink/table/sources/FilterableTableSource.java | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java
index fc144d5..a602ef7 100644
--- a/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java
+++ b/flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/FilterableTableSource.java
@@ -33,6 +33,11 @@ public interface FilterableTableSource<T> {
* have been translated in conjunctive form, and table source can only pick those predicates
* that it supports.
*
+ * <p><strong>WARNING:</strong> Flink planner will push down PlannerExpressions
+ * (which are defined in flink-table-planner module), while Blink planner will push down {@link Expression}s.
+ * So the implementation for Flink planner and Blink planner should be different and incompatible.
+ * PlannerExpression will be removed in the future.
+ *
* <p>After trying to push predicates down, we should return a new {@link TableSource}
* instance which holds all pushed down predicates. Even if we actually pushed nothing down,
* it is recommended that we still return a new {@link TableSource} instance since we will