[jira] Commented: (WW-3451) [FreemarkerManager] don't put ATTR_SESSION_MODEL into session

["Christian Wolfgang Stone (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-3451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12869967#action_12869967 ] 

Christian Wolfgang Stone commented on WW-3451:
----------------------------------------------

I would be very careful when applying this patch, as it looks like it breaks the features requested in Sitemesh.  When you say "useless in current code", I presume you mean that you have devised another method of caching the model so that Freemarker can access Struts request and session stack in Sitemesh?

Can you explain why this breaks other features?

While I didn't write the no-caching code you wish to remove, why is it redundant?  I presume you are inferring that elsewhere in the code those headers are being set?





> [FreemarkerManager]  don't put ATTR_SESSION_MODEL into session  
> ----------------------------------------------------------------
>
>                 Key: WW-3451
>                 URL: https://issues.apache.org/jira/browse/WW-3451
>             Project: Struts 2
>          Issue Type: Bug
>            Reporter: zhouyanming
>            Priority: Critical
>         Attachments: patch.txt
>
>
> put ATTR_SESSION_MODEL into session is useless in current code, and harmful for  distributed system
> and remove some other useless code,please see patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.