You are viewing a plain text version of this content. The canonical link for it is here.

Posted to derby-dev@db.apache.org by "Knut Anders Hatlen (JIRA)" <ji...@apache.org> on 2013/04/15 10:10:17 UTC

[jira] [Commented] (DERBY-6177) Cleanup suspect coding practices in org.apache.derby.catalog.types

    [ https://issues.apache.org/jira/browse/DERBY-6177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631577#comment-13631577 ] 

Knut Anders Hatlen commented on DERBY-6177:
-------------------------------------------

Using the clone() method would be more concise than the manual copying in the patch. For example:

    return (array == null) ? null : (String[]) array.clone();
                
> Cleanup suspect coding practices in org.apache.derby.catalog.types
> ------------------------------------------------------------------
>
>                 Key: DERBY-6177
>                 URL: https://issues.apache.org/jira/browse/DERBY-6177
>             Project: Derby
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Priority: Minor
>         Attachments: derby-6177-01-aa-copyArrays.diff
>
>
> Cleanup suspect coding practices such as accessor methods returning mutable objects which can be corrupted by callers.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira