You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2009/10/29 06:28:59 UTC

[jira] Created: (ZOOKEEPER-566) "reqs" four letter word (command port) returns no information

"reqs" four letter word (command port) returns no information
-------------------------------------------------------------

                 Key: ZOOKEEPER-566
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-566
             Project: Zookeeper
          Issue Type: Bug
    Affects Versions: 3.2.1
            Reporter: Patrick Hunt
            Priority: Critical
             Fix For: 3.3.0


the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.

we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-566) "reqs" four letter word (command port) returns no information

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-566:
------------------------------------

      Resolution: Fixed
    Release Note: Committed revision 835515.
          Status: Resolved  (was: Patch Available)

> "reqs" four letter word (command port) returns no information
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-566
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-566
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-566.patch
>
>
> the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.
> we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-566) "reqs" four letter word (command port) returns no information

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775336#action_12775336 ] 

Hadoop QA commented on ZOOKEEPER-566:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12424451/ZOOKEEPER-566.patch
  against trunk revision 833938.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/59/console

This message is automatically generated.

> "reqs" four letter word (command port) returns no information
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-566
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-566
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-566.patch
>
>
> the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.
> we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-566) "reqs" four letter word (command port) returns no information

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777877#action_12777877 ] 

Hudson commented on ZOOKEEPER-566:
----------------------------------

Integrated in ZooKeeper-trunk #536 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/536/])
    

> "reqs" four letter word (command port) returns no information
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-566
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-566
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-566.patch
>
>
> the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.
> we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-566) "reqs" four letter word (command port) returns no information

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-566:
-----------------------------------

    Attachment: ZOOKEEPER-566.patch

this patch removes the "reqs" command. at some point the code was refactored in such a way
that this information was no longer available. 

also fixed the dump command to output sessionid as hex

Added more detailed "cons" information - information on connections
added "srvr" command that just shows server information
added crst which resets the connection stat information (similar to srst for server stats)


> "reqs" four letter word (command port) returns no information
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-566
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-566
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-566.patch
>
>
> the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.
> we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-566) "reqs" four letter word (command port) returns no information

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-566:
-----------------------------------

    Assignee: Patrick Hunt
      Status: Patch Available  (was: Open)

> "reqs" four letter word (command port) returns no information
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-566
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-566
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-566.patch
>
>
> the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.
> we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-566) "reqs" four letter word (command port) returns no information

Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Reed updated ZOOKEEPER-566:
------------------------------------

    Hadoop Flags: [Reviewed]

> "reqs" four letter word (command port) returns no information
> -------------------------------------------------------------
>
>                 Key: ZOOKEEPER-566
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-566
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.2.1
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Critical
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-566.patch
>
>
> the four letter word "reqs" doesn't do anything - it always returns empty data. Seems that "outstanding" field is always empty and never set.
> we should remove outstanding and also update the reqs code to correctly output the outstanding requests (if not possible then remove the cmd and update docs - although this is very useful command, hate to see us lose it)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.