[GitHub] [spark] sathiyapk edited a comment on pull request #34729: [SPARK-37475][SQL] Add scale parameter to floor and ceil functions

[GitBox <gi...@apache.org>]

sathiyapk edited a comment on pull request #34729:
URL: https://github.com/apache/spark/pull/34729#issuecomment-995823221


   @viirya Thanks for your comments. I've added `ExpressionBuilder` for `ceil`/`floor` and added enough test cases in `MathFunctionsSuite`. I think we can also add some unit tests to verify StructType/Schema for `ceil`/`floor` with scale parameters by adding `xxx.sql` and `xxx.sql.out` files in `sql-tests/results`. 
   
   Do you think we can add any other tests ? If so, could you please show me an example in the source code ? Thank you. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org