You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by gi...@git.apache.org on 2017/09/18 16:10:26 UTC

[GitHub] reminisce commented on a change in pull request #7911: More sparse related docs

reminisce commented on a change in pull request #7911: More sparse related docs
URL: https://github.com/apache/incubator-mxnet/pull/7911#discussion_r139467525
 
 

 ##########
 File path: python/mxnet/ndarray/sparse.py
 ##########
 @@ -88,6 +88,8 @@ def _new_alloc_handle(stype, shape, ctx, delay_alloc, dtype, aux_types, aux_shap
         A new empty ndarray handle
     """
     hdl = NDArrayHandle()
+    for aux_t in aux_types:
+        assert(np.dtype(aux_t) == np.dtype("int64")), "only int64 is supported for aux types"
 
 Review comment:
   Is using `raise` more appropriate here? In production, users may not want to terminate their program.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services