You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Abhishek Dasgupta <a1...@linux.vnet.ibm.com> on 2016/01/31 16:22:52 UTC
Review Request 43032: Set Docker labels based on TaskInfo labels.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
-----------------------------------------------------------
Review request for mesos and Guangya Liu.
Bugs: MESOS-4446
https://issues.apache.org/jira/browse/MESOS-4446
Repository: mesos
Description
-------
Set Docker labels based on TaskInfo labels.
Diffs
-----
src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43032/diff/
Testing
-------
The following test cases in docker_tests have been changed:
DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
Thanks,
Abhishek Dasgupta
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
> On Jan. 31, 2016, 4 p.m., haosdent huang wrote:
> > src/tests/containerizer/docker_tests.cpp, line 122
> > <https://reviews.apache.org/r/43032/diff/1/?file=1227344#file1227344line122>
> >
> > Do you need verify this in inspect result?
Will you please tell a little bit more about this? Do you want to verify labels in inspect result as I found that only container name is available from the current inspect result.
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117147
-----------------------------------------------------------
On Jan. 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 3:22 p.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117147
-----------------------------------------------------------
src/docker/docker.cpp (line 533)
<https://reviews.apache.org/r/43032/#comment178237>
Do we need check docker version? Because I remember after 1.6.0, docker container starting support labels.
src/tests/containerizer/docker_tests.cpp (line 122)
<https://reviews.apache.org/r/43032/#comment178238>
Do you need verify this in inspect result?
- haosdent huang
On Jan. 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 3:22 p.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117148
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43032]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Jan. 31, 2016, 3:22 p.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117401
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43032]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 2, 2016, 8:58 a.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 8:58 a.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117784
-----------------------------------------------------------
src/docker/docker.cpp (line 548)
<https://reviews.apache.org/r/43032/#comment179048>
Shall we add some warning message here telling end user that current docker version does not support Label, and those labels are ingnored?
- Guangya Liu
On Feb. 3, 2016, 11:33 a.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 11:33 a.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117609
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43032]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 3, 2016, 11:33 a.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 11:33 a.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 6:02 p.m.)
Review request for mesos, Guangya Liu and haosdent huang.
Bugs: MESOS-4446
https://issues.apache.org/jira/browse/MESOS-4446
Repository: mesos
Description
-------
Set Docker labels based on TaskInfo labels.
Diffs (updated)
-----
src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43032/diff/
Testing
-------
The following test cases in docker_tests have been changed:
DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
Thanks,
Abhishek Dasgupta
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
> On Feb. 3, 2016, 12:04 p.m., haosdent huang wrote:
> > src/docker/docker.cpp, line 535
> > <https://reviews.apache.org/r/43032/diff/3/?file=1230896#file1230896line535>
> >
> > I think need return Error when `version.isError()`
version is a Future type and it does not have isError(), So I had to deviate a little to make the changes as you suggest. Can you review it again, please?
- Abhishek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117608
-----------------------------------------------------------
On Feb. 4, 2016, 6:18 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 6:18 p.m.)
>
>
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 3, 2016, 12:04 p.m., haosdent huang wrote:
> > src/docker/docker.cpp, line 535
> > <https://reviews.apache.org/r/43032/diff/3/?file=1230896#file1230896line535>
> >
> > I think need return Error when `version.isError()`
>
> Abhishek Dasgupta wrote:
> version is a Future type and it does not have isError(), So I had to deviate a little to make the changes as you suggest. Can you review it again, please?
Oh, sorry. We have `validateVersion` in docker.cpp, I think you could use it directly. And check whether it return error. There is a related snippet code in `Try<Owned<Docker>> Docker::create(`.
```
Try<Nothing> validateVersion = docker->validateVersion(Version(1, 0, 0));
if (validateVersion.isError()) {
return Error(validateVersion.error());
}
```
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117608
-----------------------------------------------------------
On Feb. 4, 2016, 6:18 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 6:18 p.m.)
>
>
> Review request for mesos, Guangya Liu, haosdent huang, Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117608
-----------------------------------------------------------
Fix it, then Ship it!
Ship It!
src/docker/docker.cpp (line 535)
<https://reviews.apache.org/r/43032/#comment178854>
I think need return Error when `version.isError()`
- haosdent huang
On Feb. 3, 2016, 11:33 a.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 11:33 a.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 11:33 a.m.)
Review request for mesos and Guangya Liu.
Bugs: MESOS-4446
https://issues.apache.org/jira/browse/MESOS-4446
Repository: mesos
Description
-------
Set Docker labels based on TaskInfo labels.
Diffs (updated)
-----
src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43032/diff/
Testing
-------
The following test cases in docker_tests have been changed:
DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
Thanks,
Abhishek Dasgupta
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Abhishek Dasgupta <a1...@linux.vnet.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 8:58 a.m.)
Review request for mesos and Guangya Liu.
Bugs: MESOS-4446
https://issues.apache.org/jira/browse/MESOS-4446
Repository: mesos
Description
-------
Set Docker labels based on TaskInfo labels.
Diffs (updated)
-----
src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43032/diff/
Testing
-------
The following test cases in docker_tests have been changed:
DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
Thanks,
Abhishek Dasgupta
Re: Review Request 43032: Set Docker labels based on TaskInfo labels.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43032/#review117166
-----------------------------------------------------------
src/docker/docker.cpp (lines 535 - 536)
<https://reviews.apache.org/r/43032/#comment178249>
one line
src/tests/containerizer/docker_tests.cpp (lines 105 - 106)
<https://reviews.apache.org/r/43032/#comment178250>
What about adding one more label without value but only key?
- Guangya Liu
On 一月 31, 2016, 3:22 p.m., Abhishek Dasgupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43032/
> -----------------------------------------------------------
>
> (Updated 一月 31, 2016, 3:22 p.m.)
>
>
> Review request for mesos and Guangya Liu.
>
>
> Bugs: MESOS-4446
> https://issues.apache.org/jira/browse/MESOS-4446
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Set Docker labels based on TaskInfo labels.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 7802f23585121d41c738cc28f6bcfa5e6dc9e972
> src/docker/docker.cpp 4d2f1fa14f4450b8fa3401081bf52807d2e79a7e
> src/docker/executor.cpp 654a41db843a85d953880d5145bc95ada9ed2920
> src/slave/containerizer/docker.cpp 2887cb4a01febbbf276026e584ffc466289e10c9
> src/tests/containerizer/docker_containerizer_tests.cpp 645bdcf095145097d8b8c65d592c787417883145
> src/tests/containerizer/docker_tests.cpp f0ad20e5a8252ad761e8fa42724caed31b8fae9d
> src/tests/mesos.hpp bdecd6828f07f051847b700a7cc9262a3f835b2b
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43032/diff/
>
>
> Testing
> -------
>
> The following test cases in docker_tests have been changed:
> DockerTest.ROOT_DOCKER_interface is updated to check labels are passed to docker run command through arguments.
>
>
> Thanks,
>
> Abhishek Dasgupta
>
>