You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2023/10/14 17:15:25 UTC
[PR] MINOR: cleanup warnings in Kafka Streams code base [kafka]
mjsax opened a new pull request, #14549:
URL: https://github.com/apache/kafka/pull/14549
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: cleanup warnings in Kafka Streams code base [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #14549:
URL: https://github.com/apache/kafka/pull/14549
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: cleanup warnings in Kafka Streams code base [kafka]
Posted by "ableegoldman (via GitHub)" <gi...@apache.org>.
ableegoldman commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1359737490
##########
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##########
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
@SuppressWarnings("this-escape")
public StreamsBuilder(final TopologyConfig topologyConfigs) {
- topology = getNewTopology(topologyConfigs);
+ topology = newTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new InternalStreamsBuilder(internalTopologyBuilder);
}
- protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review Comment:
I mean...there are definitely some people using named topologies, though I've made sure they are aware it is not considered a public API and not intended for public use without a KIP
Anyways given that this specific API is not even a public method I think it's fair game to remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: cleanup warnings in Kafka Streams code base [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1360033529
##########
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##########
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
@SuppressWarnings("this-escape")
public StreamsBuilder(final TopologyConfig topologyConfigs) {
- topology = getNewTopology(topologyConfigs);
+ topology = newTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new InternalStreamsBuilder(internalTopologyBuilder);
}
- protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review Comment:
This PR does not remove it, we just change the name, so code could break. But yes, it's not public API so it should be ok. Going to merge. If there are concerns raised later, we can always add a commit to revert before 3.7 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: cleanup warnings in Kafka Streams code base [kafka]
Posted by "guozhangwang (via GitHub)" <gi...@apache.org>.
guozhangwang commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1359654735
##########
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##########
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
@SuppressWarnings("this-escape")
public StreamsBuilder(final TopologyConfig topologyConfigs) {
- topology = getNewTopology(topologyConfigs);
+ topology = newTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new InternalStreamsBuilder(internalTopologyBuilder);
}
- protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review Comment:
Have we double check that there's no callers outside KS code (like in other repos) of this function? Just double checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: cleanup warnings in Kafka Streams code base [kafka]
Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #14549:
URL: https://github.com/apache/kafka/pull/14549#discussion_r1359669572
##########
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##########
@@ -87,12 +87,12 @@ public StreamsBuilder() {
*/
@SuppressWarnings("this-escape")
public StreamsBuilder(final TopologyConfig topologyConfigs) {
- topology = getNewTopology(topologyConfigs);
+ topology = newTopology(topologyConfigs);
internalTopologyBuilder = topology.internalTopologyBuilder;
internalStreamsBuilder = new InternalStreamsBuilder(internalTopologyBuilder);
}
- protected Topology getNewTopology(final TopologyConfig topologyConfigs) {
Review Comment:
I could not find anything. Maybe @ableegoldman can comment? -- Also no big deal to leave this one. In the end, we plan to remove this experimental feature in the future anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org