You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/10/22 18:28:55 UTC

[GitHub] [incubator-gobblin] arekusuri commented on a change in pull request #3136: return null when exhausted instead of omitting the last element in resultChaining iterator

arekusuri commented on a change in pull request #3136:
URL: https://github.com/apache/incubator-gobblin/pull/3136#discussion_r510371072



##########
File path: gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/ResultChainingIterator.java
##########
@@ -61,17 +61,17 @@ public boolean hasNext() {
 
   @Override
   public JsonElement next() {
+    if (!iter.hasNext()) {

Review comment:
       `if (!iter.hasNext()) {… }` meant to print out total info.
   if iter.hasNext == false, this function won’t be called.
   You can just remove the `return null` from original code.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org